Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2071403003: Revises RequestCoordinator to not try to schedule another request when previous one fails. (Closed)

Created:
4 years, 6 months ago by dougarnett
Modified:
4 years, 6 months ago
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revises RequestCoordinator to not try to schedule another request when previous one fails. This helps stop a failed request loop within single OfflinerTask run. Also adds test to confirm failed requests are not removed from the queue (subject to some retry limit in future). BUG=610521 Committed: https://crrev.com/272edd820eb1d150bfdc2081729877364c061447 Cr-Commit-Position: refs/heads/master@{#400544}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -6 lines) Patch
M components/offline_pages/background/request_coordinator.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M components/offline_pages/background/request_coordinator_unittest.cc View 2 chunks +34 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dougarnett
I think this is good change in general - but also solves a looping failed ...
4 years, 6 months ago (2016-06-17 22:22:01 UTC) #2
Pete Williamson
lgtm
4 years, 6 months ago (2016-06-17 22:39:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071403003/1
4 years, 6 months ago (2016-06-17 23:08:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 23:33:42 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 23:35:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/272edd820eb1d150bfdc2081729877364c061447
Cr-Commit-Position: refs/heads/master@{#400544}

Powered by Google App Engine
This is Rietveld 408576698