Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2071393002: More removal of SkColorProfileType... (Closed)

Created:
4 years, 6 months ago by Brian Osman
Modified:
4 years, 6 months ago
Reviewers:
msarett, bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

More removal of SkColorProfileType... Scrub GMs. Remove the gDefaultProfile thing (it's unused now), along with the command line flag that was setting it in DM and nanobench. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2071393002 Committed: https://skia.googlesource.com/skia/+/944876f2745a62a839e49275daf93a0329372e67 Committed: https://skia.googlesource.com/skia/+/52ede1d905728cdcaa98db1e4a33724f5a85c62d

Patch Set 1 #

Patch Set 2 : Squelch uninitialized variable warning #

Patch Set 3 : Restore API used in Chrome #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -80 lines) Patch
M bench/nanobench.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M dm/DM.cpp View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M gm/SkLinearBitmapPipelineGM.cpp View 2 chunks +1 line, -4 lines 0 comments Download
M gm/all_bitmap_configs.cpp View 2 chunks +8 lines, -4 lines 0 comments Download
M gm/color4f.cpp View 1 chunk +6 lines, -3 lines 0 comments Download
M gm/dftext.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M gm/gamma.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M gm/surface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/textblobgeometrychange.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M gm/textblobmixedsizes.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M gm/textblobrandomfont.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/xfermodes3.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D include/private/SkImageInfoPriv.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/core/SkImageInfo.cpp View 2 chunks +0 lines, -9 lines 0 comments Download
M src/gpu/GrContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrSurface.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 4 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/SkGrPriv.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/flags/SkCommonFlags.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/flags/SkCommonFlags.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 28 (15 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071393002/1
4 years, 6 months ago (2016-06-17 19:01:34 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot/builds/4230)
4 years, 6 months ago (2016-06-17 19:04:41 UTC) #5
Brian Osman
The conversion from GrPixelConfig back to color-space retains the current functionality, but is going to ...
4 years, 6 months ago (2016-06-17 19:05:09 UTC) #7
reed1
lwoottm lgtm
4 years, 6 months ago (2016-06-17 19:06:18 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071393002/20001
4 years, 6 months ago (2016-06-17 19:13:30 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-17 19:31:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071393002/20001
4 years, 6 months ago (2016-06-17 20:42:11 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/944876f2745a62a839e49275daf93a0329372e67
4 years, 6 months ago (2016-06-17 20:43:32 UTC) #17
egdaniel
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2074103004/ by egdaniel@google.com. ...
4 years, 6 months ago (2016-06-17 22:11:20 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071393002/40001
4 years, 6 months ago (2016-06-20 15:05:09 UTC) #21
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-20 15:21:57 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071393002/40001
4 years, 6 months ago (2016-06-20 15:23:46 UTC) #26
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 15:25:06 UTC) #28
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/52ede1d905728cdcaa98db1e4a33724f5a85c62d

Powered by Google App Engine
This is Rietveld 408576698