Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(320)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: test/cctest/asmjs/OWNERS
Issue
2071343003
:
V8. ASM-2-WASM. Validator V2. (Closed)
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: moves test-asm-validator to the asmjs cctest folder.
Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
BUILD.gn
src/asmjs/OWNERS
src/asmjs/asm-typer.h
src/asmjs/asm-typer.cc
src/asmjs/asm-types.h
src/v8.gyp
test/cctest/OWNERS
test/cctest/asmjs/OWNERS
test/cctest/asmjs/test-asm-typer.cc
test/cctest/asmjs/test-typing-asm.cc
test/cctest/cctest.gyp
test/cctest/test-asm-validator.cc
View unified diff
|
Download patch
« no previous file with comments
|
« test/cctest/OWNERS
('k') |
test/cctest/asmjs/test-asm-typer.cc »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1
# Keep in sync with src/asmjs/OWNERS.
2
1 set noparent
3 set noparent
2
4
3 ahaas@chromium.org
5 ahaas@chromium.org
4 bradnelson@chromium.org
6 bradnelson@chromium.org
5 jpp@chromium.org
7 jpp@chromium.org
6 mtrofin@chromium.org
8 mtrofin@chromium.org
7 rossberg@chromium.org
9 rossberg@chromium.org
8 titzer@chromium.org
10 titzer@chromium.org
OLD
NEW
« no previous file with comments
|
« test/cctest/OWNERS
('k') |
test/cctest/asmjs/test-asm-typer.cc »
('j') |
no next file with comments »
Issue 2071343003: V8. ASM-2-WASM. Validator V2. (Closed)
Created 4 years, 6 months ago by John
Modified 4 years, 5 months ago
Reviewers: bradnelson, bradn
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Comments: 135
This is Rietveld
408576698