V8. ASM-2-WASM. Validator V2.

src/asmjs/asm-types.h

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SRC_ASMJS_ASM_TYPES_H_
 #define SRC_ASMJS_ASM_TYPES_H_
 
 #include <string>
 
 #include "src/base/macros.h"
@@ skipping 31 matching lines @@
   /* Types used for expressing the Heap accesses. */                          \
   V(Uint8Array, "Uint8Array", 14, kAsmHeap)                                   \
   V(Int8Array, "Int8Array", 15, kAsmHeap)                                     \
   V(Uint16Array, "Uint16Array", 16, kAsmHeap)                                 \
   V(Int16Array, "Int16Array", 17, kAsmHeap)                                   \
   V(Uint32Array, "Uint32Array", 18, kAsmHeap)                                 \
   V(Int32Array, "Int32Array", 19, kAsmHeap)                                   \
   V(Float32Array, "Float32Array", 20, kAsmHeap)                               \
   V(Float64Array, "Float64Array", 21, kAsmHeap)                               \
   /* Pseudo-types used in representing heap access for fp types.*/            \
+  /* DESIGN FLAW: FloatishDoubleQ should be a base type.*/                    \

[bradn, 2016/07/11 17:55:33]

Maybe TODO ? More searchable?

[John, 2016/07/12 21:13:15]

Done.

   V(FloatishDoubleQ, "floatish|double?", 22, kAsmFloatish | kAsmDoubleQ)      \
+  /* DESIGN FLAW: FloatQDoubleQ should be a base type.*/                      \
   V(FloatQDoubleQ, "float?|double?", 23, kAsmFloatQ | kAsmDoubleQ)            \
   /* None is used to represent errors in the type checker. */                 \
   V(None, "<none>", 31, 0)
 
 // List of V(CamelName)
 #define FOR_EACH_ASM_CALLABLE_TYPE_LIST(V) \
   V(FunctionType)                          \
   V(FFIType)                               \
   V(OverloadedFunctionType)                \
   V(FunctionTableType)
@@ skipping 62 matching lines @@
  public:
   AsmFunctionType* AsFunctionType() final { return this; }
 
   void AddArgument(AsmType* type) { args_.push_back(type); }
   const ZoneVector<AsmType*> Arguments() const { return args_; }
   AsmType* ReturnType() const { return return_type_; }
 
   virtual bool IsMinMaxType() const { return false; }
   virtual bool IsFroundType() const { return false; }
 
+  AsmType* ValidateCall(AsmType* return_type,
+                        const ZoneVector<AsmType*>& args) override;
+
  protected:
   AsmFunctionType(Zone* zone, AsmType* return_type)
       : return_type_(return_type), args_(zone) {}
 
  private:
   friend AsmType;
 
   std::string Name() override;
-  AsmType* ValidateCall(AsmType* return_type,
-                        const ZoneVector<AsmType*>& args) override;
 
   AsmType* return_type_;
   ZoneVector<AsmType*> args_;
 
   DISALLOW_COPY_AND_ASSIGN(AsmFunctionType);
 };
 
 class AsmOverloadedFunctionType final : public AsmCallableType {
  public:
   AsmOverloadedFunctionType* AsOverloadedFunctionType() override {
@@ skipping 35 matching lines @@
 class AsmFunctionTableType : public AsmCallableType {
  public:
   AsmFunctionTableType* AsFunctionTableType() override { return this; }
 
   std::string Name() override;
 
   AsmType* ValidateCall(AsmType* return_type,
                         const ZoneVector<AsmType*>& args) override;
 
   size_t length() const { return length_; }
+  AsmType* signature() { return signature_; }
 
  private:
   friend class AsmType;
 
   AsmFunctionTableType(size_t length, AsmType* signature);
 
   size_t length_;
   AsmType* signature_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(AsmFunctionTableType);
@@ skipping 125 matching lines @@
   // Returns the store type if this is a heap type. AsmType::None is returned if
   // this is not a heap type.
   AsmType* StoreType();
 };
 
 }  // namespace wasm
 }  // namespace internal
 }  // namespace v8
 
 #endif  // SRC_WASM_ASM_TYPES_H_