Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2071323002: bluetooth: mac: Initial BluetoothRemoteGattCharacteristicMac implementation (Closed)

Created:
4 years, 6 months ago by jlebel
Modified:
4 years, 6 months ago
Reviewers:
ortuno
CC:
blink-reviews, chromium-reviews, haraken, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: mac: Initial BluetoothRemoteGattCharacteristicMac implementation Fix for: https://codereview.chromium.org/1950033002/ Adding initial remote characteristic implementation on OS X, with only the basic methods (e.g. GetUUID) implemented. Characteristic discovery also implemented in BluetoothRemoteGattServiceMac. BUG=609064 Committed: https://crrev.com/620327dbe7be34248528cde2425ea979f90ca8b6 Cr-Commit-Position: refs/heads/master@{#400663}

Patch Set 1 #

Patch Set 2 : Build fix #

Patch Set 3 : Merge from top of tree #

Patch Set 4 : Skip reconnect-during-disconnected-event test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+751 lines, -76 lines) Patch
M device/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M device/bluetooth/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_device_mac.h View 2 chunks +2 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_device_mac.mm View 2 chunks +39 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_peripheral_delegate.mm View 2 chunks +10 lines, -0 lines 0 comments Download
A device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h View 1 chunk +72 lines, -0 lines 0 comments Download
A device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm View 1 chunk +151 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc View 4 chunks +24 lines, -8 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_mac.h View 2 chunks +26 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_mac.mm View 4 chunks +89 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_unittest.cc View 6 chunks +25 lines, -10 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_mac.h View 3 chunks +16 lines, -0 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_mac.mm View 5 chunks +63 lines, -2 lines 0 comments Download
A device/bluetooth/test/mock_bluetooth_cbcharacteristic_mac.h View 1 chunk +23 lines, -0 lines 0 comments Download
A device/bluetooth/test/mock_bluetooth_cbcharacteristic_mac.mm View 1 1 chunk +138 lines, -0 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_cbperipheral_mac.h View 1 chunk +2 lines, -0 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_cbperipheral_mac.mm View 4 chunks +22 lines, -3 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_cbservice_mac.h View 2 chunks +9 lines, -1 line 0 comments Download
M device/bluetooth/test/mock_bluetooth_cbservice_mac.mm View 3 chunks +28 lines, -1 line 0 comments Download
M device/device_tests.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 1 chunk +4 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp View 3 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071323002/20001
4 years, 6 months ago (2016-06-17 14:15:39 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-17 15:30:31 UTC) #6
ortuno
lgtm! Hopefully it will stick this time :)
4 years, 6 months ago (2016-06-17 19:44:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071323002/20001
4 years, 6 months ago (2016-06-20 08:37:40 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/23203) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-20 08:39:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071323002/40001
4 years, 6 months ago (2016-06-20 08:58:07 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/241524)
4 years, 6 months ago (2016-06-20 09:43:07 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071323002/60001
4 years, 6 months ago (2016-06-20 11:47:19 UTC) #19
commit-bot: I haz the power
Failed to apply the patch.
4 years, 6 months ago (2016-06-20 13:03:17 UTC) #21
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 13:03:39 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/620327dbe7be34248528cde2425ea979f90ca8b6
Cr-Commit-Position: refs/heads/master@{#400663}

Powered by Google App Engine
This is Rietveld 408576698