Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2071313002: [mb] Remove redundant flags (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[mb] Remove redundant flags BUG=chromium:616035 TBR=kjellander@chromium.org, vogelheim@chromium.org, jochen@chromium.org NOTRY=true Committed: https://crrev.com/6a39399763adff81ede005b2f992174f93c85ee5 Cr-Commit-Position: refs/heads/master@{#37067}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M infra/mb/mb_config.pyl View 1 chunk +0 lines, -1 line 1 comment Download

Messages

Total messages: 10 (5 generated)
Michael Achenbach
TBR https://codereview.chromium.org/2071313002/diff/1/infra/mb/mb_config.pyl File infra/mb/mb_config.pyl (right): https://codereview.chromium.org/2071313002/diff/1/infra/mb/mb_config.pyl#newcode56 infra/mb/mb_config.pyl:56: 'debug', 'static', 'goma', 'v8_enable_slow_dchecks', Those flags are specified ...
4 years, 6 months ago (2016-06-17 12:25:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071313002/1
4 years, 6 months ago (2016-06-17 12:25:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 12:27:44 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6a39399763adff81ede005b2f992174f93c85ee5 Cr-Commit-Position: refs/heads/master@{#37067}
4 years, 6 months ago (2016-06-17 12:30:05 UTC) #9
kjellander_chromium
4 years, 6 months ago (2016-06-20 21:07:34 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698