Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 20713002: Regression test for existing bug in String::MakeExternal. (Closed)

Created:
7 years, 5 months ago by Michael Starzinger
Modified:
7 years, 5 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Regression test for existing bug in String::MakeExternal. R=yangguo@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15903

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M test/cctest/cctest.status View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 5 months ago (2013-07-26 11:29:42 UTC) #1
Yang
On 2013/07/26 11:29:42, Michael Starzinger wrote: lgtm.
7 years, 5 months ago (2013-07-26 11:32:25 UTC) #2
Michael Starzinger
7 years, 5 months ago (2013-07-26 11:38:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15903 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698