Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2071273003: additional includes needed for MIPS toolchain after move of hashmap (Closed)

Created:
4 years, 6 months ago by asaka
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

additional includes needed for MIPS toolchain after move of hashmap Follow up from https://codereview.chromium.org/2010243003 BUG=v8:5050 Committed: https://crrev.com/11eb9d224e2e82bee0f90b3cf3e034ed3edc7868 Cr-Commit-Position: refs/heads/master@{#37103}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/base/hashmap.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/profiler/strings-storage.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071273003/1
4 years, 6 months ago (2016-06-17 11:42:19 UTC) #2
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started ...
4 years, 6 months ago (2016-06-17 11:42:20 UTC) #4
asaka
@yang, can you help look at this fix for our MIPS toolchains?
4 years, 6 months ago (2016-06-17 11:51:01 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-20 11:37:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071273003/1
4 years, 6 months ago (2016-06-20 12:46:47 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 13:17:32 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 13:19:21 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11eb9d224e2e82bee0f90b3cf3e034ed3edc7868
Cr-Commit-Position: refs/heads/master@{#37103}

Powered by Google App Engine
This is Rietveld 408576698