Remove PlatformFile from database/vfs_backend

Remove PlatformFile from database/vfs_backend

BUG=322664
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260054

[rvargas (doing something else), 2014-03-21 18:36:25]

PTAL

[michaeln, 2014-03-24 18:57:20]

https://codereview.chromium.org/207123002/diff/20001/content/browser/renderer...
File content/browser/renderer_host/database_message_filter.cc (right):

https://codereview.chromium.org/207123002/diff/20001/content/browser/renderer...
content/browser/renderer_host/database_message_filter.cc:164: target_handle =
IPC::TakeFileHandleForProcess(file.Pass(), PeerHandle());
What about the earlier calls to file.TakePlatformFile for the incognito case?
That method sounds like 'file' will be left without a platformfile upon return.

[michaeln, 2014-03-24 22:59:08]

https://codereview.chromium.org/207123002/diff/20001/content/browser/renderer...
File content/browser/renderer_host/database_message_filter.cc (right):

https://codereview.chromium.org/207123002/diff/20001/content/browser/renderer...
content/browser/renderer_host/database_message_filter.cc:164: target_handle =
IPC::TakeFileHandleForProcess(file.Pass(), PeerHandle());
On 2014/03/24 18:57:20, michaeln wrote:
> What about the earlier calls to file.TakePlatformFile for the incognito case?
> That method sounds like 'file' will be left without a platformfile upon
return.

oh, i see the else clause dups file_handle directly in that case.

I don't see a base::File::Pass() method in the sources? Is that recently added?

[rvargas (doing something else), 2014-03-25 00:51:13]

Thanks

https://codereview.chromium.org/207123002/diff/20001/content/browser/renderer...
File content/browser/renderer_host/database_message_filter.cc (right):

https://codereview.chromium.org/207123002/diff/20001/content/browser/renderer...
content/browser/renderer_host/database_message_filter.cc:164: target_handle =
IPC::TakeFileHandleForProcess(file.Pass(), PeerHandle());
On 2014/03/24 22:59:08, michaeln wrote:
> On 2014/03/24 18:57:20, michaeln wrote:
> > What about the earlier calls to file.TakePlatformFile for the incognito
case?
> > That method sounds like 'file' will be left without a platformfile upon
> return.
> 
> oh, i see the else clause dups file_handle directly in that case.
> 
> I don't see a base::File::Pass() method in the sources? Is that recently
added?

Pass() comes from MOVE_ONLY_TYPE_FOR_CPP_03 at the top of the class.

[michaeln, 2014-03-25 01:21:12]

lgtm

https://codereview.chromium.org/207123002/diff/20001/content/browser/renderer...
File content/browser/renderer_host/database_message_filter.cc (right):

https://codereview.chromium.org/207123002/diff/20001/content/browser/renderer...
content/browser/renderer_host/database_message_filter.cc:164: target_handle =
IPC::TakeFileHandleForProcess(file.Pass(), PeerHandle());
On 2014/03/25 00:51:14, rvargas wrote:
> Pass() comes from MOVE_ONLY_TYPE_FOR_CPP_03 at the top of the class.

duh, thnx

[rvargas (doing something else), 2014-03-25 01:41:59]

The CQ bit was checked by rvargas@chromium.org

[commit-bot: I haz the power, 2014-03-25 01:42:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rvargas@chromium.org/207123002/20001

[commit-bot: I haz the power, 2014-03-25 02:21:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-25 02:21:04]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[rvargas (doing something else), 2014-03-25 03:05:47]

+jochen for content

[rvargas (doing something else), 2014-03-27 00:56:34]

On 2014/03/25 03:05:47, rvargas wrote:
> +jochen for content

ping?

[jochen (gone - plz use gerrit), 2014-03-27 14:25:20]

lgtm

[rvargas (doing something else), 2014-03-27 17:44:35]

The CQ bit was checked by rvargas@chromium.org

[commit-bot: I haz the power, 2014-03-27 17:45:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rvargas@chromium.org/207123002/20001

[commit-bot: I haz the power, 2014-03-27 21:38:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 21:38:16]

Retried try job too often on win_rel for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[rvargas (doing something else), 2014-03-27 23:49:42]

The CQ bit was checked by rvargas@chromium.org

[commit-bot: I haz the power, 2014-03-27 23:51:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rvargas@chromium.org/207123002/20001

[commit-bot: I haz the power, 2014-03-28 01:13:40]

Change committed as 260054