Use metadata when launching WebAPKs.

chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.webapps;
 
 import android.content.Intent;
+import android.graphics.Bitmap;
 
 import org.chromium.base.ContextUtils;
 import org.chromium.base.library_loader.LibraryProcessType;
 import org.chromium.chrome.browser.ChromeApplication;
 import org.chromium.chrome.browser.ShortcutHelper;
 import org.chromium.chrome.browser.banners.AppBannerManager;
 import org.chromium.chrome.browser.externalnav.ExternalNavigationParams;
 import org.chromium.chrome.browser.tab.InterceptNavigationDelegateImpl;
 import org.chromium.chrome.browser.tab.Tab;
 import org.chromium.chrome.browser.tab.TabDelegateFactory;
 import org.chromium.chrome.browser.tab.TabRedirectHandler;
 import org.chromium.components.navigation_interception.NavigationParams;
 import org.chromium.content.browser.ChildProcessCreationParams;
+import org.chromium.content.browser.ScreenOrientationProvider;
 import org.chromium.content_public.browser.LoadUrlParams;
 import org.chromium.ui.base.PageTransition;
 import org.chromium.webapk.lib.client.WebApkServiceConnectionManager;
 import org.chromium.webapk.lib.common.WebApkSandboxedProcessService;
 
 /**
  * An Activity is designed for WebAPKs (native Android apps) and displays a webapp in a nearly
  * UI-less Chrome.
  */
 public class WebApkActivity extends WebappActivity {
     @Override
     protected void onNewIntent(Intent intent) {
         super.onNewIntent(intent);
         // We could bring a WebAPK hosted WebappActivity to foreground and navigate it to a
         // different URL. For example, WebAPK "foo" is launched and navigates to
         // "www.foo.com/foo". In Chrome, user clicks a link "www.foo.com/bar" in Google search
         // results. After clicking the link, WebAPK "foo" is brought to foreground, and
         // loads the page of "www.foo.com/bar" at the same time.
         // The extra {@link ShortcutHelper.EXTRA_URL} provides the URL that the WebAPK will
         // navigate to.
         String overrideUrl = intent.getStringExtra(ShortcutHelper.EXTRA_URL);
         if (overrideUrl != null && isInitialized()
                 && !overrideUrl.equals(getActivityTab().getUrl())) {
             getActivityTab().loadUrl(
                     new LoadUrlParams(overrideUrl, PageTransition.AUTO_TOPLEVEL));
         }
     }
 
     @Override
-    protected void initializeSplashScreenWidgets(final int backgroundColor) {
-        // TODO(hanxi): Removes this function and use {@link WebApkActivity}'s implementation
-        // when WebAPKs are registered in WebappRegistry.
-        initializeSplashScreenWidgets(backgroundColor, null);
+    protected void initializeWebappData() {

[pkotwicz, 2016/06/20 18:26:14]

- Can this function be in WebappActivity instead of WebapkActivity? I think that
updating the splash screen as the Web Manifest changes is useful for generic Web
apps not just WebAPKs If it is not, then we should only update the splashscreen
for WebAPKs if we get a new WebAPK from the server.  We should get approval from
dfalcantara@ before merging this code into WebappActivity. I have been bad at
guessing "what the real OWNERS think" lately
- I am not a fan of all of the WebappInfo setters. Can we rename this function
to resolveWebappInfo() and have it call onWebappInfoResolved(WebappInfo info,
Bitmap bitmap) when it has retrieved the data from WebappDataStorage 

[Xi Han, 2016/06/22 15:55:28]

I am not sure whether this suits Webapps, because they also update the meta data
from the new launching Intent, while WebAPK prefer to use the metadata. Webapp
could benefit from this code, but after the efforts to keep the meta data
updated. So now isn't the right time to change Webapp's behavior, we'd better
keep the changes within WebApkActivity.
Add WebappDataStorage#createWebappInfo() to create a webappInfo from the
storage, but we still use the URL of the current mWebappInfo since that is the
latest URL to navigate.

[pkotwicz, 2016/06/23 01:16:37]

I don't mind waiting till the "fetch updated Web Manifest data" is implemented
for WebAPKs before we port the feature to regular Web apps too.

+        WebappRegistry.getWebappDataStorage(this, getId(),
+                new WebappRegistry.FetchWebappDataStorageCallback() {
+                    @Override
+                    public void onWebappDataStorageRetrieved(WebappDataStorage storage) {
+                        if (storage == null) {

[pkotwicz, 2016/06/20 18:26:14]

Currently, WebappRegistry#registerWebapp() is not called for WebAPKs in
ShorcutHelper. Don't we currently always go through the early return?

Can you post the CL which calls WebappRegistry#registerWebapp() as prerequisite
to this one. My preference is to land CLs in an order so that each CL produces a
visible change. (and it is easy to test the changes caused by each CL)

[Xi Han, 2016/06/22 15:55:28]

Yes, we always go through the early return for now.
 
I haven't figured out the best place to call WebappRegistry#registerWebapp(),
but it should be somewhere when we find the storage is null.

[pkotwicz, 2016/06/23 01:16:37]

I think that there will be multiple places which will call
WebappRegistry#registerWebapp(). One of those places should be
ShortcutHelper#addShortcut(). Otherwise there will be no splashscreen image the
first time that the WebAPK is launched. I am OK if we guess what the WebAPK's
package name is for now (ShortcutHelper#guessWebApkPackageName())

I think that we should add a place which calls WebappRegistry#registerWebapp()
*somewhere* even if that place is suboptimal either in this CL or in a CL which
preceeds this one

[pkotwicz, 2016/06/27 19:23:38]

It looks like you missed this comment

[Xi Han, 2016/06/27 20:04:10]

Sorry, just forgot to reply in here. I add the registerWebapp() call when the
storage is null, since this is a place that we don't need to guess the package
name.

[pkotwicz, 2016/06/28 19:00:11]

I see the call to registerWebapp() now. Sorry that I missed it

+                            initializeSplashScreenWidgets(initializeWebappDataInternal(), null);
+                            return;
+                        }
+                        // Update WebappInfo for the WebAPK. Changes in fields like backgroundColor,
+                        // themeColor, orientation won't request re-minting a WebAPK, but will
+                        // update the metadata in the SharedPreference. The updated values are
+                        // used when launching a WebAPK.
+                        // TODO(hanxi): Introduces data fetcher to detect web manifest changes and
+                        // update SharedPreference for WebAPKs.
+                        mWebappInfo.setBackgroundColor(storage.getBackgroundColor());
+                        final int backgroundColor = initializeWebappDataInternal();
+
+                        mWebappInfo.setThemeColor(storage.getThemeColor());
+
+                        int orientation = storage.getOrientation();
+                        if (mWebappInfo.orientation() != orientation) {
+                            mWebappInfo.setOrientation(orientation);
+                            ScreenOrientationProvider.lockOrientation(
+                                    (byte) mWebappInfo.orientation(), WebApkActivity.this);
+                        }
+

[pkotwicz, 2016/06/20 18:26:14]

Shouldn't we also update WebappInfo#name()?
I am unsure whether we should update WebappInfo#shortName(). That's the one
which shows up in the app list and in recents

[Xi Han, 2016/06/22 15:55:28]

Good point. Creating a new WebappInfo will have the updated values.

+                        storage.updateLastUsedTime();
+
+                        // Retrieve the splash image if it exists.
+                        storage.getSplashScreenImage(new WebappDataStorage.FetchCallback<Bitmap>() {
+                            @Override
+                            public void onDataRetrieved(Bitmap splashImage) {
+                                initializeSplashScreenWidgets(backgroundColor, splashImage);
+                            }
+                        });
+                    }
+                }
+        );
     }
 
     @Override
     protected TabDelegateFactory createTabDelegateFactory() {
         return new WebappDelegateFactory(this) {
             @Override
             public InterceptNavigationDelegateImpl createInterceptNavigationDelegate(Tab tab) {
                 return new InterceptNavigationDelegateImpl(tab) {
                     @Override
                     public ExternalNavigationParams.Builder buildExternalNavigationParams(
@@ skipping 66 matching lines @@
         ChildProcessCreationParams params = chrome.getChildProcessCreationParams();
         if (isForWebApk) {
             int extraBindFlag = params == null ? 0 : params.getExtraBindFlags();
             params = new ChildProcessCreationParams(getWebappInfo().webApkPackageName(),
                     extraBindFlag, LibraryProcessType.PROCESS_CHILD,
                     WebApkSandboxedProcessService.class);
         }
         ChildProcessCreationParams.set(params);
     }
 }