Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2071213002: Rename WebMemoryPressureListener -> WebMemoryCoordinator (Closed)

Created:
4 years, 6 months ago by bashi
Modified:
4 years, 6 months ago
Reviewers:
tkent, haraken, kinuko
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, kinuko+watch, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename WebMemoryPressureListener -> WebMemoryCoordinator Rationale: We are implementing memory coordinator and memory pressure APIs will be deprecated once memory coordinator is readly. BUG=617492 Committed: https://crrev.com/5e843acff129ab607e19539265a46617d7a4f92a Cr-Commit-Position: refs/heads/master@{#400391}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -48 lines) Patch
M content/renderer/render_thread_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/web/WebMemoryCoordinator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/web/WebMemoryPressureListener.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/web/web.gypi View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/public/web/WebMemoryCoordinator.h View 1 chunk +3 lines, -3 lines 0 comments Download
D third_party/WebKit/public/web/WebMemoryPressureListener.h View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071213002/1
4 years, 6 months ago (2016-06-17 04:06:07 UTC) #2
bashi
PTAL
4 years, 6 months ago (2016-06-17 04:38:38 UTC) #4
haraken
LGTM
4 years, 6 months ago (2016-06-17 04:40:44 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-17 05:28:20 UTC) #7
tkent
lgtm
4 years, 6 months ago (2016-06-17 06:00:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071213002/1
4 years, 6 months ago (2016-06-17 06:41:24 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/202433)
4 years, 6 months ago (2016-06-17 06:48:55 UTC) #12
bashi
kinuko-san, could you review content/renderer? Just renaming.
4 years, 6 months ago (2016-06-17 07:02:59 UTC) #14
kinuko
lgtm
4 years, 6 months ago (2016-06-17 07:21:05 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071213002/1
4 years, 6 months ago (2016-06-17 07:39:56 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 07:44:48 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 07:47:23 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e843acff129ab607e19539265a46617d7a4f92a
Cr-Commit-Position: refs/heads/master@{#400391}

Powered by Google App Engine
This is Rietveld 408576698