Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2071183002: Revert of WTF: Simplify RefPtr::operator bool. (Closed)

Created:
4 years, 6 months ago by DaleCurtis
Modified:
4 years, 6 months ago
Reviewers:
Nico, jbroman
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of WTF: Simplify RefPtr::operator bool. (patchset #1 id:1 of https://codereview.chromium.org/2072703002/ ) Reason for revert: Broke x64 build, see original patch for details. Original issue's description: > WTF: Simplify RefPtr::operator bool. > > The problematic case in String::find on ARM should now be gone, and so this > should be both simpler and equally fast. > > BUG=607208 > > Committed: https://crrev.com/2b6875bfd954d336432702512d1ffe4c83343d2b > Cr-Commit-Position: refs/heads/master@{#400315} TBR=thakis@chromium.org,jbroman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=607208 Committed: https://crrev.com/2862dfadaa7fc3b96a2f56facb00ef736fbe70d9 Cr-Commit-Position: refs/heads/master@{#400325}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M third_party/WebKit/Source/wtf/PassRefPtr.h View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/RefPtr.h View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
DaleCurtis
Created Revert of WTF: Simplify RefPtr::operator bool.
4 years, 6 months ago (2016-06-17 01:19:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071183002/1
4 years, 6 months ago (2016-06-17 01:20:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 01:20:50 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 01:22:45 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2862dfadaa7fc3b96a2f56facb00ef736fbe70d9
Cr-Commit-Position: refs/heads/master@{#400325}

Powered by Google App Engine
This is Rietveld 408576698