Add StructTraits for AcceleratedWidget instances.

Add StructTraits for AcceleratedWidget instances.

Provide StructTraits for sending AcceleratedWidgets between
processes.

BUG=620927
Committed: https://crrev.com/4c267402a084f4873c3fbbaa79443f19960a7ef2
Cr-Commit-Position: refs/heads/master@{#401742}

[rjkroege, 2016-06-17 00:53:03]

The CQ bit was checked by rjkroege@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-17 00:53:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2071163002/1

[rjkroege, 2016-06-17 01:02:25]

rjkroege@chromium.org changed reviewers:
+ rockot@chromium.org

[rjkroege, 2016-06-17 01:02:25]

Per discussion the other day. PTAL.

[commit-bot: I haz the power, 2016-06-17 01:07:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 01:07:16]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[rjkroege, 2016-06-17 19:26:35]

The CQ bit was checked by rjkroege@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-17 19:26:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2071163002/20001

[Ken Rockot(use gerrit already), 2016-06-17 19:37:11]

lgtm but nitty nit for the description: they are struct traits, not a struct
trait. StructTraits<T> is a set of traits for type T

[rjkroege, 2016-06-17 19:50:52]

Description was changed from

==========
Add a struct trait for AcceleratedWidget instances.

Provide a struct-trait implementation for sending AcceleratedWidgets between
processes.

BUG=620927
==========

to

==========
Add a struct trait for AcceleratedWidget instances.

Provide a struct-trait implementation for sending AcceleratedWidgets between
processes.

BUG=620927
==========

[commit-bot: I haz the power, 2016-06-17 19:52:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 19:52:32]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[rjkroege, 2016-06-17 22:58:13]

Description was changed from

==========
Add a struct trait for AcceleratedWidget instances.

Provide a struct-trait implementation for sending AcceleratedWidgets between
processes.

BUG=620927
==========

to

==========
Add StructTraits for AcceleratedWidget instances.

Provide a struct-trait implementation for sending AcceleratedWidgets between
processes.

BUG=620927
==========

[rjkroege, 2016-06-17 22:58:22]

The CQ bit was checked by rjkroege@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-17 22:58:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2071163002/40001

[rjkroege, 2016-06-17 23:20:38]

Description was changed from

==========
Add StructTraits for AcceleratedWidget instances.

Provide a struct-trait implementation for sending AcceleratedWidgets between
processes.

BUG=620927
==========

to

==========
Add StructTraits for AcceleratedWidget instances.

Provide StructTraits for sending AcceleratedWidgets between
processes.

BUG=620927
==========

[commit-bot: I haz the power, 2016-06-18 00:02:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-18 00:02:21]

Dry run: This issue passed the CQ dry run.

[rjkroege, 2016-06-18 00:15:52]

rjkroege@chromium.org changed reviewers:
+ sadrul@chromium.org

[rjkroege, 2016-06-18 00:16:36]

rjkroege@chromium.org changed reviewers:
+ tsepez@chromium.org
- sadrul@chromium.org

[rjkroege, 2016-06-18 00:17:02]

rjkroege@chromium.org changed reviewers:
+ sadrul@chromium.org

[rjkroege, 2016-06-18 00:17:36]

+tsepez@ for security review.

+sadrul@ for general OWNERS

[sadrul, 2016-06-20 19:31:12]

lgtm

[rjkroege, 2016-06-21 18:22:45]

rjkroege@chromium.org changed reviewers:
+ dcheng@chromium.org
- tsepez@chromium.org

[rjkroege, 2016-06-21 18:22:46]

ptal

[rjkroege, 2016-06-21 18:24:33]

rjkroege@chromium.org changed reviewers:
- dcheng@chromium.org

[rjkroege, 2016-06-21 18:25:18]

rjkroege@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2016-06-21 20:59:25]

Do we have existing examples of code today that has to send HWNDs or other
window handles over IPC? Mainly I'm just curious if there's any implications to
randomly trusting the handle is valid.

[Ken Rockot(use gerrit already), 2016-06-21 21:05:43]

I was able to find one example though there may be others:
https://cs.chromium.org/chromium/src/chrome/common/chrome_utility_messages.h?...,
which uses
https://cs.chromium.org/chromium/src/ipc/ipc_message_utils.h?rcl=0&l=1027
because of
https://cs.chromium.org/chromium/src/ipc/ipc_message_utils.h?rcl=0&l=630

On Tue, Jun 21, 2016 at 1:59 PM, <dcheng@chromium.org> wrote:

> Do we have existing examples of code today that has to send HWNDs or other
> window handles over IPC? Mainly I'm just curious if there's any
> implications to
> randomly trusting the handle is valid.
>
> https://codereview.chromium.org/2071163002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[rjkroege, 2016-06-21 21:24:50]

On 2016/06/21 20:59:25, dcheng wrote:
> Do we have existing examples of code today that has to send HWNDs or other
> window handles over IPC? Mainly I'm just curious if there's any implications
to
> randomly trusting the handle is valid.

FWIW: all the uses of the traits here are sending a handle from a more trusted
to a less trusted process.

[rjkroege, 2016-06-21 21:27:02]

On 2016/06/21 21:24:50, rjkroege wrote:
> On 2016/06/21 20:59:25, dcheng wrote:
> > Do we have existing examples of code today that has to send HWNDs or other
> > window handles over IPC? Mainly I'm just curious if there's any implications
> to
> > randomly trusting the handle is valid.
> 
> FWIW: all the uses of the traits here are sending a handle from a more trusted
> to a less trusted process.

I should clarify. There are no uses of this code currently in tree. In a
forthcoming CL, the mojo interface using this trait will only be calls from a
more trusted to a less trusted process.

[dcheng, 2016-06-22 14:17:13]

lgtm

[dcheng, 2016-06-22 14:18:08]

https://codereview.chromium.org/2071163002/diff/40001/ui/gfx/mojo/accelerated...
File ui/gfx/mojo/accelerated_widget_struct_traits.h (right):

https://codereview.chromium.org/2071163002/diff/40001/ui/gfx/mojo/accelerated...
ui/gfx/mojo/accelerated_widget_struct_traits.h:17: return uint64_t(widget);
Nit: static_cast here and below rather than using a function-style cast.

[rjkroege, 2016-06-23 14:30:53]

The CQ bit was checked by rjkroege@chromium.org

[rjkroege, 2016-06-23 14:30:54]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
sadrul@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2071163002/#ps60001
(title: "formatting")

[commit-bot: I haz the power, 2016-06-23 14:31:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2071163002/60001

[commit-bot: I haz the power, 2016-06-23 14:51:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 14:51:35]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[rjkroege, 2016-06-23 21:04:49]

The CQ bit was checked by rjkroege@chromium.org

[rjkroege, 2016-06-23 21:04:50]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
sadrul@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2071163002/#ps80001
(title: "review comments")

[rjkroege, 2016-06-23 21:05:09]

On 2016/06/22 14:18:08, dcheng wrote:
>
https://codereview.chromium.org/2071163002/diff/40001/ui/gfx/mojo/accelerated...
> File ui/gfx/mojo/accelerated_widget_struct_traits.h (right):
> 
>
https://codereview.chromium.org/2071163002/diff/40001/ui/gfx/mojo/accelerated...
> ui/gfx/mojo/accelerated_widget_struct_traits.h:17: return uint64_t(widget);
> Nit: static_cast here and below rather than using a function-style cast.

Done.

[commit-bot: I haz the power, 2016-06-23 21:05:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2071163002/80001

[commit-bot: I haz the power, 2016-06-23 22:13:40]

Description was changed from

==========
Add StructTraits for AcceleratedWidget instances.

Provide StructTraits for sending AcceleratedWidgets between
processes.

BUG=620927
==========

to

==========
Add StructTraits for AcceleratedWidget instances.

Provide StructTraits for sending AcceleratedWidgets between
processes.

BUG=620927
==========

[commit-bot: I haz the power, 2016-06-23 22:13:42]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-23 22:15:47]

Description was changed from

==========
Add StructTraits for AcceleratedWidget instances.

Provide StructTraits for sending AcceleratedWidgets between
processes.

BUG=620927
==========

to

==========
Add StructTraits for AcceleratedWidget instances.

Provide StructTraits for sending AcceleratedWidgets between
processes.

BUG=620927

Committed: https://crrev.com/4c267402a084f4873c3fbbaa79443f19960a7ef2
Cr-Commit-Position: refs/heads/master@{#401742}
==========

[commit-bot: I haz the power, 2016-06-23 22:15:48]

Patchset 5 (id:??) landed as
https://crrev.com/4c267402a084f4873c3fbbaa79443f19960a7ef2
Cr-Commit-Position: refs/heads/master@{#401742}