mojo/edk/embedder/platform_channel_utils_posix.cc - Issue 2071143003: Various changes to make Mojo work under NaCl non-sfi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/edk/embedder/platform_channel_utils_posix.cc

Issue 2071143003: Various changes to make Mojo work under NaCl non-sfi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix GYP build. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/edk/embedder/platform_channel_utils_posix.cc

diff --git a/mojo/edk/embedder/platform_channel_utils_posix.cc b/mojo/edk/embedder/platform_channel_utils_posix.cc

index d2a9b566c6af2eaa07906ebe1c2067beda7b58e6..9f4e9f90a3d31b502097d3c95cf891ed557aef09 100644

--- a/mojo/edk/embedder/platform_channel_utils_posix.cc

+++ b/mojo/edk/embedder/platform_channel_utils_posix.cc

@@ -59,7 +59,8 @@ ssize_t PlatformChannelWrite(PlatformHandle h,

DCHECK(bytes);

DCHECK_GT(num_bytes, 0u);

-#if defined(OS_MACOSX)

+#if defined(OS_MACOSX) || defined(OS_NACL_NONSFI)

+ // send() doesn't appear to work under NaCl-nonsfi.

Mark Seaborn 2016/06/20 21:12:15 You can be more definite: "doesn't appear to work"

Anand Mistry (off Chromium) 2016/06/21 00:32:27 Done.

return HANDLE_EINTR(write(h.handle, bytes, num_bytes));

#else

return send(h.handle, bytes, num_bytes, kSendFlags);

« no previous file with comments | « mojo/edk/embedder/platform_channel_pair_posix.cc ('k') | mojo/edk/system/node_channel.cc » ('j') | no next file with comments »