Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2071143003: Various changes to make Mojo work under NaCl non-sfi. (Closed)

Created:
4 years, 6 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Various changes to make Mojo work under NaCl non-sfi. BUG=604282 Committed: https://crrev.com/8b9cc4edcc43fd6b9abf8847b103cea94cb5859b Cr-Commit-Position: refs/heads/master@{#400868}

Patch Set 1 #

Patch Set 2 : Fix GYP build. #

Total comments: 2

Patch Set 3 : rebase and comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -104 lines) Patch
M components/nacl_nonsfi.gyp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/edk/embedder/platform_channel_pair_posix.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/embedder/platform_channel_utils_posix.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/node_channel.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/system/node_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/node_controller.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/mojo_edk.gypi View 1 2 2 chunks +8 lines, -2 lines 0 comments Download
M mojo/mojo_edk_nacl.gyp View 1 2 3 chunks +29 lines, -88 lines 0 comments Download
M ppapi/ppapi_proxy_nacl.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Anand Mistry (off Chromium)
4 years, 6 months ago (2016-06-17 03:50:09 UTC) #2
Anand Mistry (off Chromium)
mseaborn: for nacl_nonsfi.gyp raymes: for ppapi/ppapi_proxy_nacl.gyp
4 years, 6 months ago (2016-06-17 06:22:17 UTC) #4
Ken Rockot(use gerrit already)
lgtm
4 years, 6 months ago (2016-06-17 16:40:55 UTC) #5
raymes
lgtm
4 years, 6 months ago (2016-06-20 00:12:34 UTC) #6
Mark Seaborn
LGTM https://codereview.chromium.org/2071143003/diff/20001/mojo/edk/embedder/platform_channel_utils_posix.cc File mojo/edk/embedder/platform_channel_utils_posix.cc (right): https://codereview.chromium.org/2071143003/diff/20001/mojo/edk/embedder/platform_channel_utils_posix.cc#newcode63 mojo/edk/embedder/platform_channel_utils_posix.cc:63: // send() doesn't appear to work under NaCl-nonsfi. ...
4 years, 6 months ago (2016-06-20 21:12:15 UTC) #7
Anand Mistry (off Chromium)
https://codereview.chromium.org/2071143003/diff/20001/mojo/edk/embedder/platform_channel_utils_posix.cc File mojo/edk/embedder/platform_channel_utils_posix.cc (right): https://codereview.chromium.org/2071143003/diff/20001/mojo/edk/embedder/platform_channel_utils_posix.cc#newcode63 mojo/edk/embedder/platform_channel_utils_posix.cc:63: // send() doesn't appear to work under NaCl-nonsfi. On ...
4 years, 6 months ago (2016-06-21 00:32:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071143003/40001
4 years, 6 months ago (2016-06-21 00:33:01 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-21 01:29:36 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 01:31:38 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/8b9cc4edcc43fd6b9abf8847b103cea94cb5859b
Cr-Commit-Position: refs/heads/master@{#400868}

Powered by Google App Engine
This is Rietveld 408576698