Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Issue 2071123003: Mark webaudio tests as needing manual rebaseline (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Raymond Toy
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark webaudio tests as needing manual rebaseline V8 is changing Math.exp to be more accurate and this breaks some WebAudio tests. Mark them as needs manual rebaseline so the V8 change can land. We'll rebaseline these after the change lands. The tests actually pass, but the printed results are slightly different. R=rtoy@chromium.org BUG=chromium:620786 NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/994938c2a8601705e3b44a95fc932b38ba683426 Committed: https://crrev.com/65be401d97b1f097e5d785034246e4ed5a5cf048 Cr-Original-Commit-Position: refs/heads/master@{#400347} Cr-Commit-Position: refs/heads/master@{#400385}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-17 03:40:40 UTC) #1
Raymond Toy
lgtm
4 years, 6 months ago (2016-06-17 03:41:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071123003/1
4 years, 6 months ago (2016-06-17 03:41:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 03:46:32 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/994938c2a8601705e3b44a95fc932b38ba683426 Cr-Commit-Position: refs/heads/master@{#400347}
4 years, 6 months ago (2016-06-17 03:48:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071123003/1
4 years, 6 months ago (2016-06-17 07:02:02 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 07:06:23 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 07:07:55 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65be401d97b1f097e5d785034246e4ed5a5cf048
Cr-Commit-Position: refs/heads/master@{#400385}

Powered by Google App Engine
This is Rietveld 408576698