Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

Issue 2071053003: Invalidate as DisplayItemClient when PaintLayer is setNeedsRepaint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@TrackObjectInvalidation
Patch Set: Invalidate as DisplayItemClient when PaintLayer is setNeedsRepaint Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayer.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp b/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
index ba87f0278c47ca356ad4304f16b0597ccc68760c..755f9709765f8e87302fe610b55738f7b971e511 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
@@ -201,7 +201,7 @@ void PaintController::copyCachedSubsequence(const DisplayItemList& currentList,
DCHECK(currentIt != m_currentPaintArtifact.getDisplayItemList().end());
DCHECK(currentIt->hasValidClient());
#if CHECK_DISPLAY_ITEM_CLIENT_ALIVENESS
- CHECK(currentIt->client().isAlive());
+ CHECK(clientCacheIsValid(currentIt->client()) || !currentIt->isCacheable());
#endif
updatedList.appendByMoving(*currentIt, currentList.visualRect(currentIt - m_currentPaintArtifact.getDisplayItemList().begin()), gpuAnalyzer);
++currentIt;
@@ -280,7 +280,9 @@ void PaintController::commitNewDisplayItems(const LayoutSize& offsetFromLayoutOb
if (newDisplayItemHasCachedType) {
DCHECK(newDisplayItem.isCached());
- DCHECK(clientCacheIsValid(newDisplayItem.client()));
+#if CHECK_DISPLAY_ITEM_CLIENT_ALIVENESS
+ CHECK(clientCacheIsValid(newDisplayItem.client()));
+#endif
if (!isSynchronized) {
currentIt = findOutOfOrderCachedItem(newDisplayItemId, outOfOrderIndexContext);
« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayer.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698