Issue 207103003: Add *explicit* keyword to avoid implicit type conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 207103003: Add explicit keyword to avoid implicit type conversion (Closed)

Created:
6 years, 9 months ago by gyuyoung-inactive

Modified:
6 years, 9 months ago

Reviewers:
haraken, Inactive

CC:
blink-reviews, krit, kouhei+svg_chromium.org, ed+blinkwatch_opera.com, fs, dglazkov+blink, apavlov+blink_chromium.org, gyuyoung.kim_webkit.org, darktears, f(malita), Stephen Chennney, rune+blink, pdr., rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Add *explicit* keyword to avoid implicit type conversion Constructors of RemoteFontFaceSource, SVGDocumentExtensions, XMLDocumentParserScope, and WorkerScriptDebugServer need to use *explicit* keyword because they have an argument. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169709

Patch Set 1 #

Patch Set 2 : Updated #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
M	Source/bindings/v8/WorkerScriptDebugServer.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/RemoteFontFaceSource.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGDocumentExtensions.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/xml/parser/XMLDocumentParserScope.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/207103003/20001

6 years, 9 months ago (2014-03-20 23:35:44 UTC) #3

Message was sent while issue was closed.

LGTM