Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: components/crash_strings.grdp

Issue 2070993002: List all crashes in chrome://crashes, including those not uploaded (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: unittest Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/crash_strings.grdp
diff --git a/components/crash_strings.grdp b/components/crash_strings.grdp
index dc42a243f615333b7f4f44d8b3610633f5703c27..a6dfe1055740ade0a6f3db950199ff6c915012b9 100644
--- a/components/crash_strings.grdp
+++ b/components/crash_strings.grdp
@@ -10,9 +10,15 @@
<message name="IDS_CRASH_CRASH_HEADER_FORMAT" desc="Format for crash entry headings on chrome://crashes">
Crash ID <ph name="CRASH_ID">$1<ex>8fa95dbb6f2ec862</ex></ph> (<ph name="CRASH_LOCAL_ID">$2<ex>Chrome</ex></ph>)
</message>
- <message name="IDS_CRASH_CRASH_TIME_FORMAT" desc="Format for crash entry occurence time on chrome://crashes">
+ <message name="IDS_CRASH_CRASH_TIME_FORMAT" desc="Format for crash entry occurrence time on chrome://crashes">
Automatically reported <ph name="CRASH_TIME">$1<ex>Tuesday, January 25, 2011 2:58:02 PM</ex></ph>
</message>
+ <message name="IDS_CRASH_CRASH_NOT_UPLOADED" desc="Format for crash entry occurrence on chrome://crashes that was not uploaded to the server">
+ Crash report captured on <ph name="CRASH_TIME">$1<ex>Tuesday, January 25, 2011 2:58:02 PM</ex></ph> was not uploaded
+ </message>
+ <message name="IDS_CRASH_CRASH_PENDING_UPLOAD" desc="Format for crash entry occurrence on chrome://crashes that was has not yet been uploaded to the server">
Mark Mentovai 2016/06/20 17:55:21 Might not be “pending upload”. Might just be pendi
scottmg 2016/06/20 21:08:55 Done.
+ Pending crash report captured on <ph name="CRASH_TIME">$1<ex>Tuesday, January 25, 2011 2:58:02 PM</ex></ph>
Mark Mentovai 2016/06/20 17:55:21 “Pending” isn’t really self-explanatory to users.
scottmg 2016/06/20 21:08:55 Hmm, yeah, that's a bit sticky. How about this?
+ </message>
<message name="IDS_CRASH_BUG_LINK_LABEL" desc="Link text for filing a crash bug on chrome://crashes">
Provide additional details
</message>

Powered by Google App Engine
This is Rietveld 408576698