Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: components/crash/core/browser/resources/crashes.js

Issue 2070993002: List all crashes in chrome://crashes, including those not uploaded (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/crash/core/browser/resources/crashes.js
diff --git a/components/crash/core/browser/resources/crashes.js b/components/crash/core/browser/resources/crashes.js
index 9bd33c9f30b344e20e24575ca7f2ebb1d59e1031..15b364a7e2f91f76c577ec6452b57890701051a8 100644
--- a/components/crash/core/browser/resources/crashes.js
+++ b/components/crash/core/browser/resources/crashes.js
@@ -45,50 +45,70 @@ function updateCrashList(enabled, dynamicBackend, crashes, version, os) {
crash['local_id'] = productName;
var crashBlock = document.createElement('div');
+ if (crash['state'] != 'uploaded')
+ crashBlock.className = 'notUploaded';
var title = document.createElement('h3');
- title.textContent = loadTimeData.getStringF('crashHeaderFormat',
- crash['id'],
- crash['local_id']);
+ var uploaded = crash['state'] == 'uploaded';
+ if (uploaded) {
+ title.textContent = loadTimeData.getStringF('crashHeaderFormat',
+ crash['id'],
+ crash['local_id']);
+ } else {
+ title.textContent = loadTimeData.getStringF('crashHeaderFormatLocalOnly',
+ crash['local_id']);
+ }
crashBlock.appendChild(title);
- var date = document.createElement('p');
- date.textContent = loadTimeData.getStringF('crashTimeFormat',
- crash['time']);
- crashBlock.appendChild(date);
- var linkBlock = document.createElement('p');
- var link = document.createElement('a');
- var commentLines = [
- 'IMPORTANT: Your crash has already been automatically reported ' +
- 'to our crash system. Please file this bug only if you can provide ' +
- 'more information about it.',
- '',
- '',
- 'Chrome Version: ' + version,
- 'Operating System: ' + os,
- '',
- 'URL (if applicable) where crash occurred:',
- '',
- 'Can you reproduce this crash?',
- '',
- 'What steps will reproduce this crash? (If it\'s not ' +
- 'reproducible, what were you doing just before the crash?)',
- '1.', '2.', '3.',
- '',
- '****DO NOT CHANGE BELOW THIS LINE****',
- 'Crash ID: crash/' + crash.id
- ];
- var params = {
- template: 'Crash Report',
- comment: commentLines.join('\n'),
- };
- var href = 'https://code.google.com/p/chromium/issues/entry';
- for (var param in params) {
- href = appendParam(href, param, params[param]);
+ if (uploaded) {
+ var date = document.createElement('p');
+ date.textContent = loadTimeData.getStringF('crashTimeFormat',
+ crash['time']);
+ crashBlock.appendChild(date);
+ var linkBlock = document.createElement('p');
+ var link = document.createElement('a');
+ var commentLines = [
+ 'IMPORTANT: Your crash has already been automatically reported ' +
+ 'to our crash system. Please file this bug only if you can provide ' +
+ 'more information about it.',
+ '',
+ '',
+ 'Chrome Version: ' + version,
+ 'Operating System: ' + os,
+ '',
+ 'URL (if applicable) where crash occurred:',
+ '',
+ 'Can you reproduce this crash?',
+ '',
+ 'What steps will reproduce this crash? (If it\'s not ' +
+ 'reproducible, what were you doing just before the crash?)',
+ '1.', '2.', '3.',
+ '',
+ '****DO NOT CHANGE BELOW THIS LINE****',
+ 'Crash ID: crash/' + crash.id
+ ];
+ var params = {
+ template: 'Crash Report',
+ comment: commentLines.join('\n'),
+ };
+ var href = 'https://code.google.com/p/chromium/issues/entry';
+ for (var param in params) {
+ href = appendParam(href, param, params[param]);
+ }
+ link.href = href;
+ link.target = '_blank';
+ link.textContent = loadTimeData.getString('bugLinkText');
+ linkBlock.appendChild(link);
+ crashBlock.appendChild(linkBlock);
+ } else if (crash['state'] == 'pending') {
+ var pending = document.createElement('p');
+ pending.textContent = loadTimeData.getStringF('crashPending',
+ crash['time']);
+ crashBlock.appendChild(pending);
+ } else if (crash['state'] == 'not_uploaded') {
+ var not_uploaded = document.createElement('p');
+ not_uploaded.textContent = loadTimeData.getStringF('crashNotUploaded',
+ crash['time']);
+ crashBlock.appendChild(not_uploaded);
}
- link.href = href;
- link.target = '_blank';
- link.textContent = loadTimeData.getString('bugLinkText');
- linkBlock.appendChild(link);
- crashBlock.appendChild(linkBlock);
crashSection.appendChild(crashBlock);
}

Powered by Google App Engine
This is Rietveld 408576698