Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1744)

Unified Diff: components/crash/content/app/crashpad.h

Issue 2070993002: List all crashes in chrome://crashes, including those not uploaded (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/crash/content/app/crashpad.h
diff --git a/components/crash/content/app/crashpad.h b/components/crash/content/app/crashpad.h
index b081fc690326ad95b3f012d3cdcb29b8f951a312..47a30943aae9d06407478a0036c60b4f71f45a88 100644
--- a/components/crash/content/app/crashpad.h
+++ b/components/crash/content/app/crashpad.h
@@ -72,10 +72,18 @@ void SetUploadsEnabled(bool enabled);
// available in the browser process.
bool GetUploadsEnabled();
-struct UploadedReport {
+enum class ReportUploadState {
+ NotUploaded,
+ Pending,
+ Uploaded,
+};
+
+struct Report {
std::string local_id;
+ time_t capture_time;
std::string remote_id;
- time_t creation_time;
+ time_t upload_time;
+ ReportUploadState state;
};
// Obtains a list of reports uploaded to the collection server. This function
@@ -83,13 +91,7 @@ struct UploadedReport {
// database that have been successfully uploaded will be included in this list.
// The list will be sorted in descending order by report creation time (newest
// reports first).
-//
-// TODO(mark): The about:crashes UI expects to show only uploaded reports. If it
-// is ever enhanced to work well with un-uploaded reports, those should be
-// returned as well. Un-uploaded reports may have a pending upload, may have
-// experienced upload failure, or may have been collected while uploads were
-// disabled.
-void GetUploadedReports(std::vector<UploadedReport>* uploaded_reports);
+void GetReports(std::vector<Report>* reports);
#if BUILDFLAG(ENABLE_KASKO)
// Returns a copy of the current crash keys for Kasko.

Powered by Google App Engine
This is Rietveld 408576698