Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: chrome/app/chrome_exe_main_win.cc

Issue 2070993002: List all crashes in chrome://crashes, including those not uploaded (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app/chrome_exe_main_win.cc
diff --git a/chrome/app/chrome_exe_main_win.cc b/chrome/app/chrome_exe_main_win.cc
index 6eeb475d7c8fa8e7ff4eee533ea85bc1590f008c..6268c73326b35fb0c7678720eec6206adf80f048 100644
--- a/chrome/app/chrome_exe_main_win.cc
+++ b/chrome/app/chrome_exe_main_win.cc
@@ -45,8 +45,8 @@ namespace {
base::LazyInstance<ChromeCrashReporterClient>::Leaky g_chrome_crash_client =
LAZY_INSTANCE_INITIALIZER;
-base::LazyInstance<std::vector<crash_reporter::UploadedReport>>::Leaky
- g_uploaded_reports = LAZY_INSTANCE_INITIALIZER;
+base::LazyInstance<std::vector<crash_reporter::Report>>::Leaky g_crash_reports =
+ LAZY_INSTANCE_INITIALIZER;
// List of switches that it's safe to rendezvous early with. Fast start should
// not be done if a command line contains a switch not in this set.
@@ -200,12 +200,12 @@ bool RemoveAppCompatFlagsEntry() {
// CrashUploadListCrashpad. Note that we do not pass an std::vector here,
// because we do not want to allocate/free in different modules. The returned
// pointer is read-only.
-extern "C" __declspec(dllexport) void GetUploadedReportsImpl(
- const crash_reporter::UploadedReport** reports,
+extern "C" __declspec(dllexport) void GetCrashReportsImpl(
+ const crash_reporter::Report** reports,
size_t* report_count) {
- crash_reporter::GetUploadedReports(g_uploaded_reports.Pointer());
- *reports = g_uploaded_reports.Pointer()->data();
- *report_count = g_uploaded_reports.Pointer()->size();
+ crash_reporter::GetReports(g_crash_reports.Pointer());
+ *reports = g_crash_reports.Pointer()->data();
+ *report_count = g_crash_reports.Pointer()->size();
}
#if !defined(WIN_CONSOLE_APP)
« no previous file with comments | « no previous file | chrome/browser/crash_upload_list_crashpad.cc » ('j') | chrome/browser/crash_upload_list_crashpad.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698