List all crashes in chrome://crashes, including those not uploaded

components/upload_list/upload_list.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_UPLOAD_LIST_UPLOAD_LIST_H_
 #define COMPONENTS_UPLOAD_LIST_UPLOAD_LIST_H_
 
 #include <stddef.h>
 
 #include <string>
 #include <vector>
 
 #include "base/files/file_path.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/threading/thread_checker.h"
 #include "base/time/time.h"
 
 namespace base {
 class SequencedTaskRunner;
 class SequencedWorkerPool;
 }
 
 // Loads and parses an upload list text file of the format
-// upload_time,upload_id[,local_id[,capture_time]]
-// upload_time,upload_id[,local_id[,capture_time]]
+// upload_time,upload_id[,local_id[,capture_time[,state]]]
+// upload_time,upload_id[,local_id[,capture_time[,state]]]
 // etc.
-// where each line represents an upload. |upload_time| and |capture_time| are
-// in Unix time. Must be used from the UI thread. The loading and parsing is
-// done on a blocking pool task runner. A line may or may not contain
-// |local_id| and |capture_time|.
+// where each line represents an upload. |upload_time| and |capture_time| are in
+// Unix time. |state| is an int in the range of UploadInfo::State. Must be used
+// from the UI thread. The loading and parsing is done on a blocking pool task
+// runner. A line may or may not contain |local_id|, |capture_time|, and
+// |state|.
 class UploadList : public base::RefCountedThreadSafe<UploadList> {
  public:
   struct UploadInfo {
+    enum class State {
+      NotUploaded = 0,
+      Pending = 1,
+      Uploaded = 2,
+    };
+
     UploadInfo(const std::string& upload_id,
                const base::Time& upload_time,
                const std::string& local_id,
-               const base::Time& capture_time);
+               const base::Time& capture_time,
+               State state);
     UploadInfo(const std::string& upload_id, const base::Time& upload_time);
     ~UploadInfo();
 
     std::string upload_id;

[Mark Mentovai, 2016/06/20 17:55:21]

Comment that these fields are only valid in the Uploaded state now.

[scottmg, 2016/06/20 21:08:55]

Done.

     base::Time upload_time;
 
     // ID for locally stored data that may or may not be uploaded.
     std::string local_id;
 
     // The time the data was captured. This is useful if the data is stored
     // locally when captured and uploaded at a later time.
     base::Time capture_time;
+
+    State state;
   };
 
   class Delegate {
    public:
     // Invoked when the upload list has been loaded. Will be called on the
     // UI thread.
     virtual void OnUploadListAvailable() = 0;
 
    protected:
     virtual ~Delegate() {}
@@ skipping 45 matching lines @@
   Delegate* delegate_;
 
   const base::FilePath upload_log_path_;
 
   scoped_refptr<base::SequencedWorkerPool> worker_pool_;
 
   DISALLOW_COPY_AND_ASSIGN(UploadList);
 };
 
 #endif  // COMPONENTS_UPLOAD_LIST_UPLOAD_LIST_H_