Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 2070983002: Move headers in include/utils/win to src/utils/win. (Closed)

Created:
4 years, 6 months ago by bungeman-skia
Modified:
4 years, 6 months ago
Reviewers:
hal.canary, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move headers in include/utils/win to src/utils/win. These headers are not intended for external use and are only used in src. Committed: https://skia.googlesource.com/skia/+/2853f007289997c27e736243913bfb43cf9b16bb

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Really rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -345 lines) Patch
M gyp/utils.gyp View 4 chunks +7 lines, -14 lines 0 comments Download
M gyp/utils.gypi View 2 chunks +4 lines, -4 lines 0 comments Download
D include/utils/win/SkAutoCoInitialize.h View 1 chunk +0 lines, -31 lines 0 comments Download
D include/utils/win/SkHRESULT.h View 1 chunk +0 lines, -62 lines 0 comments Download
D include/utils/win/SkIStream.h View 1 chunk +0 lines, -135 lines 0 comments Download
D include/utils/win/SkTScopedComPtr.h View 1 1 chunk +0 lines, -77 lines 0 comments Download
A + src/utils/win/SkAutoCoInitialize.h View 1 chunk +1 line, -1 line 0 comments Download
A + src/utils/win/SkHRESULT.h View 2 chunks +8 lines, -8 lines 0 comments Download
A + src/utils/win/SkIStream.h View 1 chunk +1 line, -1 line 0 comments Download
A + src/utils/win/SkTScopedComPtr.h View 1 2 3 chunks +16 lines, -12 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070983002/1
4 years, 6 months ago (2016-06-16 20:32:08 UTC) #3
bungeman-skia
Gotta hide 'em all.
4 years, 6 months ago (2016-06-16 21:01:38 UTC) #6
reed1
api lgtm
4 years, 6 months ago (2016-06-16 21:03:52 UTC) #7
mtklein
lgtm
4 years, 6 months ago (2016-06-16 21:30:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070983002/1
4 years, 6 months ago (2016-06-16 21:30:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070983002/40001
4 years, 6 months ago (2016-06-16 22:14:18 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/2853f007289997c27e736243913bfb43cf9b16bb
4 years, 6 months ago (2016-06-16 22:31:46 UTC) #19
hal.canary
4 years, 6 months ago (2016-06-17 14:01:37 UTC) #21
Message was sent while issue was closed.
+1

Powered by Google App Engine
This is Rietveld 408576698