Issue 2070933002: Fix shutdown crash in settings app monitor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2070933002: Fix shutdown crash in settings app monitor. (Closed)

Created:
4 years, 6 months ago by grt (UTC plus 2)

Modified:
4 years, 6 months ago

Reviewers:
Patrick Monette, grt (UTC plus 2)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

Fix shutdown crash in settings app monitor. Don't assume that the caller's task runner will outlive the monitor. BUG=611827 R=pmonette@chromium.org Review-Url: https://codereview.chromium.org/2065673002 Cr-Commit-Position: refs/heads/master@{#399528} (cherry picked from commit 2c76bfb795b85473a03397b185dce94f7c263de3) TBR=grt@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/af9f7fdfda79a235f62a3bc6045d3771f2408a4b

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	chrome/browser/win/settings_app_monitor.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 2 (1 generated)

grt (UTC plus 2)

4 years, 6 months ago (2016-06-16 19:33:42 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
af9f7fdfda79a235f62a3bc6045d3771f2408a4b.