Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 207093002: android: Remove last two md5sum calls from gyp files. (Closed)

Created:
6 years, 9 months ago by Nico
Modified:
6 years, 9 months ago
Reviewers:
cjhopman
CC:
chromium-reviews
Visibility:
Public.

Description

android: Remove last two md5sum calls from gyp files. Use the timestamp of a filelist instead of the md5sum call. No intended behavior change. BUG=177552 R=cjhopman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258455

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M build/java.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M build/java_apk.gypi View 1 6 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
6 years, 9 months ago (2014-03-20 22:58:40 UTC) #1
cjhopman
https://codereview.chromium.org/207093002/diff/1/build/java.gypi File build/java.gypi (right): https://codereview.chromium.org/207093002/diff/1/build/java.gypi#newcode188 build/java.gypi:188: 'inputs_list_file': '>|(java_resources.<(_target_name).gypcmd >@(resource_input_paths) @>(dependencies_res_files))' s/@>/>@ https://codereview.chromium.org/207093002/diff/1/build/java_apk.gypi File build/java_apk.gypi (right): ...
6 years, 9 months ago (2014-03-20 23:05:19 UTC) #2
Nico
https://codereview.chromium.org/207093002/diff/1/build/java.gypi File build/java.gypi (right): https://codereview.chromium.org/207093002/diff/1/build/java.gypi#newcode188 build/java.gypi:188: 'inputs_list_file': '>|(java_resources.<(_target_name).gypcmd >@(resource_input_paths) @>(dependencies_res_files))' On 2014/03/20 23:05:19, cjhopman wrote: ...
6 years, 9 months ago (2014-03-20 23:08:01 UTC) #3
cjhopman
lgtm
6 years, 9 months ago (2014-03-20 23:12:36 UTC) #4
Nico
6 years, 9 months ago (2014-03-20 23:22:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r258455 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698