Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2070913002: Make PaymentRequest.abort() integration tests reliable. (Closed)

Created:
4 years, 6 months ago by please use gerrit instead
Modified:
4 years, 6 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make PaymentRequest.abort() integration tests reliable. PaymentRequest.abort() integration tests could fail on smaller Android screens, because DOMUtils.clickNode() is unable to click on buttons that are outside of the view window. The abort integration test was using two buttons: [buy] and [abort], one above the other. When the CVC entry was showing, the keyboard was hiding the bottom part of the page, where [abort] button resides. Thus DOMUtils.clickNode() was unable to to click the [abort] button for the test. This does not happen on the build bots. BUG=608223 Committed: https://crrev.com/376650fbafe88c3616b3401681f4a51521e13fb5 Cr-Commit-Position: refs/heads/master@{#400815}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/test/data/android/payments/payment_request_abort_test.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
please use gerrit instead
dfalcantara@, ptal
4 years, 6 months ago (2016-06-16 17:51:06 UTC) #3
gone
lgtm
4 years, 6 months ago (2016-06-20 21:30:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070913002/1
4 years, 6 months ago (2016-06-20 21:38:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 22:40:35 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 22:44:03 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/376650fbafe88c3616b3401681f4a51521e13fb5
Cr-Commit-Position: refs/heads/master@{#400815}

Powered by Google App Engine
This is Rietveld 408576698