Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2688)

Unified Diff: chrome/BUILD.gn

Issue 2070903002: Add an XPC service to handle alert notifications on mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_builder_add_response
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | chrome/browser/notifications/notification_platform_bridge_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 268328b6710a39f18f7404924e3ba3402d5cf181..ce1c5324740dce6d7e539dcc18d844b486340169 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -472,6 +472,22 @@ if (is_win) {
}
}
+ if (enable_xpc_notifications) {
+ bundle_data("chrome_framework_services") {
+ sources = [
+ "$root_out_dir/AlertNotificationService.xpc",
+ ]
+
+ outputs = [
+ "{{bundle_root_dir}}/XPCServices/{{source_file_part}}",
+ ]
+
+ public_deps = [
+ "//chrome/browser/ui/cocoa/notifications:alert_notification_xpc_service",
+ ]
+ }
+ }
+
tweak_info_plist("chrome_app_plist") {
info_plist = "app/app-Info.plist"
_keystone_arg = "0"
@@ -1002,6 +1018,10 @@ if (is_win) {
deps += [ ":default_apps" ]
}
+ if (enable_xpc_notifications) {
+ deps += [ ":chrome_framework_services" ]
+ }
+
ldflags = [
"-Wl,-install_name,@executable_path/../Versions/$chrome_version_full/$chrome_framework_name.framework/$chrome_framework_name",
"-compatibility_version",
« no previous file with comments | « BUILD.gn ('k') | chrome/browser/notifications/notification_platform_bridge_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698