chrome/browser/ui/cocoa/notifications/notification_service_delegate.h - Issue 2070903002: Add an XPC service to handle alert notifications on mac

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/notifications/notification_service_delegate.h

Issue 2070903002: Add an XPC service to handle alert notifications on mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_builder_add_response

Patch Set: rebased Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/cocoa/notifications/alert_notification_service.mm ('K') | « chrome/browser/ui/cocoa/notifications/alert_notification_service.mm ('k') | chrome/browser/ui/cocoa/notifications/notification_service_delegate.mm » ('j') | chrome/browser/ui/cocoa/notifications/notification_service_delegate.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_COCOA_NOTIFICATIONS_NOTIFICATION_SERVICE_DELEGATE_H_

	6 #define CHROME_BROWSER_UI_COCOA_NOTIFICATIONS_NOTIFICATION_SERVICE_DELEGATE_H_

	7

	8 #import <Foundation/Foundation.h>

	9

	10 #include "base/mac/foundation_util.h"

	11 #import "chrome/browser/ui/cocoa/notifications/notification_service_delegate.h"

	12

	13 @interface NotificationCenterDelegate
	Robert Sesek 2016/09/29 14:23:05 There's no @implementation for this class? There's no @implementation for this class? Miguel Garcia 2016/10/03 16:07:51 Indeed, the ServiceDelegate below implements both Show quoted text On 2016/09/29 14:23:05, Robert Sesek wrote: > There's no @implementation for this class? Indeed, the ServiceDelegate below implements both interfaces. Removed this.
	14 : NSObject<NSUserNotificationCenterDelegate> {

	15 }

	16 @end

	17

	18 @interface ServiceDelegate

	19 : NSObject<NSXPCListenerDelegate, NSUserNotificationCenterDelegate> {
	Robert Sesek 2016/09/29 14:23:05 Can omit the curlies here. Can omit the curlies here. Miguel Garcia 2016/10/03 16:07:51 Done. Show quoted text On 2016/09/29 14:23:05, Robert Sesek wrote: > Can omit the curlies here. Done.
	20 }

	21

	22 // The connection used to talk back to Chrome.

	23 @property(assign, nullable) NSXPCConnection* connection;
	Robert Sesek 2016/09/29 14:23:05 nonatomic as well nonatomic as well Miguel Garcia 2016/10/03 16:07:51 Done. Show quoted text On 2016/09/29 14:23:05, Robert Sesek wrote: > nonatomic as well Done.
	24

	25
	Robert Sesek 2016/09/29 14:23:05 nit: extra blank line nit: extra blank line Miguel Garcia 2016/10/03 16:07:51 Done. Show quoted text On 2016/09/29 14:23:05, Robert Sesek wrote: > nit: extra blank line Done.
	26 @end

	27

	28 #endif // CHROME_BROWSER_UI_COCOA_NOTIFICATIONS_NOTIFICATION_SERVICE_DELEGATE_H _

OLD	NEW