chrome/browser/ui/cocoa/notifications/alert_notification_service.mm - Issue 2070903002: Add an XPC service to handle alert notifications on mac

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/notifications/alert_notification_service.mm

Issue 2070903002: Add an XPC service to handle alert notifications on mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_builder_add_response

Patch Set: rebased Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/cocoa/notifications/BUILD.gn ('K') | « chrome/browser/ui/cocoa/notifications/alert_notification_service.h ('k') | chrome/browser/ui/cocoa/notifications/notification_service_delegate.h » ('j') | chrome/browser/ui/cocoa/notifications/notification_service_delegate.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #import "chrome/browser/ui/cocoa/notifications/alert_notification_service.h"

	6

	7 #include "base/mac/scoped_nsobject.h"
	Robert Sesek 2016/09/29 14:23:05 #import for both of these, since they're ObjC #import for both of these, since they're ObjC Miguel Garcia 2016/10/03 16:07:50 Done. Show quoted text On 2016/09/29 14:23:05, Robert Sesek wrote: > #import for both of these, since they're ObjC Done.
	8 #include "chrome/browser/ui/cocoa/notifications/notification_builder_mac.h"

	9

	10 @class NSUserNotification;
	Robert Sesek 2016/09/29 14:23:05 Don't need these forward declarations since you im Don't need these forward declarations since you import Foundation in the header. Miguel Garcia 2016/10/03 16:07:51 I removed NSUserNotification but for NSUserNotific Show quoted text On 2016/09/29 14:23:05, Robert Sesek wrote: > Don't need these forward declarations since you import Foundation in the header. I removed NSUserNotification but for NSUserNotificationCenter it still barfs with partially defined errors if I don't forward declare it. ../../chrome/browser/ui/cocoa/notifications/alert_notification_service.mm:21:5: error: 'NSUserNotificationCenter' is only available on macOS 10_8 or newer [-Werror,-Wunguarded-availability] [[NSUserNotificationCenter defaultUserNotificationCenter] ^~~~~~~~~~~~~~~~~~~~~~~~ /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSUserNotification.h:116:12: note: 'NSUserNotificationCenter' has been explicitly marked partial here @interface NSUserNotificationCenter : NSObject {
	11 @class NSUserNotificationCenter;

	12

	13 @implementation AlertNotificationService

	14

	15 - (void)deliverNotification:(NSDictionary*)notificationData {

	16 base::scoped_nsobject<NotificationBuilder> builder(

	17 [[NotificationBuilder alloc] initWithDictionary:notificationData]);

	18

	19 NSUserNotification* toast = [builder buildUserNotification];

	20

	21 [[NSUserNotificationCenter defaultUserNotificationCenter]

	22 deliverNotification:toast];

	23 }

	24

	25 @end

OLD	NEW