Issue 2070883002: Fix extension installed bubble sizing for cases where there's no body

Issue 2070883002: Fix extension installed bubble sizing for cases where there's no body (Closed)

Created:
4 years, 6 months ago by Evan Stade

Modified:
4 years, 6 months ago

Reviewers:
msw

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fix extension installed bubble sizing for cases where there's no body text. BUG=618983 Committed: https://crrev.com/eb814f63fb1f396192cee63a86feb2582716bdcc Cr-Commit-Position: refs/heads/master@{#400204}

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 12 (5 generated)

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070883002/1

4 years, 6 months ago (2016-06-16 17:07:43 UTC) #4

msw

lgtm. I wonder if uninstall or other bubbles might have the same issue.

4 years, 6 months ago (2016-06-16 17:25:14 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070883002/1

4 years, 6 months ago (2016-06-16 18:05:06 UTC) #8

commit-bot: I haz the power

4 years, 6 months ago (2016-06-16 18:13:57 UTC) #12

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/eb814f63fb1f396192cee63a86feb2582716bdcc
Cr-Commit-Position: refs/heads/master@{#400204}