Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2070863002: [x64] Fix the assembler and the disassembler. (Closed)

Created:
4 years, 6 months ago by epertoso
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Small fixes in the assembler and disassembler. Disassembler: added decoding of a few instructions that were previously unsupported, fixed the decoding of pextr. Assembler: pmulld(XMMRegister, Operand) was actually emitting a pmuludq. punpckldq(XMMRegister, XMMRegister) was implemented a second time as punpackldq. BUG= Committed: https://crrev.com/c534bd41a028d7dd8d79e932b619433ce9e82d10 Cr-Commit-Position: refs/heads/master@{#37059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -42 lines) Patch
M src/x64/assembler-x64.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/x64/assembler-x64.cc View 3 chunks +10 lines, -19 lines 0 comments Download
M src/x64/disasm-x64.cc View 8 chunks +59 lines, -19 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
epertoso
4 years, 6 months ago (2016-06-17 08:43:47 UTC) #4
Jarin
lgtm
4 years, 6 months ago (2016-06-17 08:54:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070863002/1
4 years, 6 months ago (2016-06-17 09:01:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 09:27:04 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 09:28:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c534bd41a028d7dd8d79e932b619433ce9e82d10
Cr-Commit-Position: refs/heads/master@{#37059}

Powered by Google App Engine
This is Rietveld 408576698