Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2070823002: Replaced elements also need to check for flexbox when computing height (Closed)

Created:
4 years, 6 months ago by cbiesinger
Modified:
4 years, 6 months ago
Reviewers:
dgrogan, eae
CC:
chromium-reviews, cbiesinger, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replaced elements also need to check for flexbox when computing height LayoutReplaced uses hasAutoHeightOrContainingBlockWithAutoHeight() to see to use the specified height. But Flexbox adds some cases where heights should be considered definite, so this function needs to check for it too. (computePercentageLogicalHeight already has the check. Longer-term, we should consider whether hasAutoHeightOrContainingBlockWithAutoHeight can be implemented using computePercentageLogicalHeight) R=eae@chromium.org,dgrogan@chromium.org BUG=499766 Committed: https://crrev.com/aaffb0ea84732045f9151c5ce7c43d92bf0c5f35 Cr-Commit-Position: refs/heads/master@{#400156}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/css3/flexbox/percentage-height-replaced-element.html View 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
cbiesinger
4 years, 6 months ago (2016-06-16 13:34:01 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070823002/1
4 years, 6 months ago (2016-06-16 13:34:08 UTC) #3
eae
LGTM Nice test
4 years, 6 months ago (2016-06-16 14:56:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070823002/1
4 years, 6 months ago (2016-06-16 15:05:25 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 15:10:23 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 15:10:33 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 15:12:07 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aaffb0ea84732045f9151c5ce7c43d92bf0c5f35
Cr-Commit-Position: refs/heads/master@{#400156}

Powered by Google App Engine
This is Rietveld 408576698