chrome/browser/ui/ash/window_positioner.cc - Issue 20708005: Refactor most recently used window tracking into a separate class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/window_positioner.cc

Issue 20708005: Refactor most recently used window tracking into a separate class. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Address comments. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/wallpaper_private_api.cc ('k') | chrome/browser/ui/window_sizer/window_sizer_ash.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/window_positioner.cc

diff --git a/chrome/browser/ui/ash/window_positioner.cc b/chrome/browser/ui/ash/window_positioner.cc

index 04fa3f291689336d6fb2c56a90d2809725290244..41ad8dd74157298258c4f881f9d4c352a3084ad0 100644

--- a/chrome/browser/ui/ash/window_positioner.cc

+++ b/chrome/browser/ui/ash/window_positioner.cc

@@ -5,7 +5,7 @@

#include "chrome/browser/ui/ash/window_positioner.h"

#include "ash/shell.h"

-#include "ash/wm/window_cycle_controller.h"

+#include "ash/wm/mru_window_tracker.h"

#include "ash/wm/window_resizer.h"

#include "ash/wm/window_util.h"

#include "ui/aura/window.h"

@@ -100,7 +100,7 @@ gfx::Rect WindowPositioner::SmartPopupPosition(

const gfx::Rect& work_area,

int grid) {

const std::vector<aura::Window*> windows =

- ash::WindowCycleController::BuildWindowList(NULL, false);

+ ash::MruWindowTracker::BuildWindowList(false);

std::vector<const gfx::Rect*> regions;

// Process the window list and check if we can bail immediately.

« no previous file with comments | « chrome/browser/chromeos/extensions/wallpaper_private_api.cc ('k') | chrome/browser/ui/window_sizer/window_sizer_ash.cc » ('j') | no next file with comments »