Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2070773002:
Reland: [PCv2] Add tracing category needed for computing ttfmp (Closed)
|
Created:
4 years, 6 months ago by Kunihiko Sakamoto Modified:
4 years, 6 months ago CC:
chromium-reviews, telemetry-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReland: [PCv2] Add tracing category needed for computing ttfmp
The time-to-first-meaningful-paint computation requires extra tracing categories to be enabled.
This CL enables recording of the category in PCv2.
https://github.com/catapult-project/catapult/blob/master/tracing/tracing/metrics/system_health/first_paint_metric.html
This is a reland of https://codereview.chromium.org/2049593002/ with
disabling the benchmark on reference build. In the reference build, the
disabled-by-default-blink.debug.layout category brows up trace size and
causes d8 crash.
BUG=615605, 619254
Committed: https://crrev.com/e598d9f6f9d6bf4cd90c46503cb0c207791a02db
Cr-Commit-Position: refs/heads/master@{#400426}
Patch Set 1 #
Messages
Total messages: 21 (11 generated)
Description was changed from ========== WIP BUG=619254 ========== to ========== WIP BUG=619254 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
Description was changed from ========== WIP BUG=619254 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== Reland: [PCv2] Add tracing category needed for computing ttfmp The time-to-first-meaningful-paint computation requires extra tracing categories to be enabled. This CL enables recording of the category in PCv2. https://github.com/catapult-project/catapult/blob/master/tracing/tracing/metr... This is a reland of https://codereview.chromium.org/2049593002/ with disabling the benchmark on reference build. In the reference build, the disabled-by-default-blink.debug.layout category brows up trace size and causes d8 crash. BUG=615605,619254 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
The CQ bit was checked by ksakamoto@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070773002/1
ksakamoto@chromium.org changed reviewers: + kouhei@chromium.org, nednguyen@google.com
lgtm. Please wait for Ned
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_s5_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_...)
lgtm
The CQ bit was checked by ksakamoto@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070773002/1
Description was changed from ========== Reland: [PCv2] Add tracing category needed for computing ttfmp The time-to-first-meaningful-paint computation requires extra tracing categories to be enabled. This CL enables recording of the category in PCv2. https://github.com/catapult-project/catapult/blob/master/tracing/tracing/metr... This is a reland of https://codereview.chromium.org/2049593002/ with disabling the benchmark on reference build. In the reference build, the disabled-by-default-blink.debug.layout category brows up trace size and causes d8 crash. BUG=615605,619254 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== Reland: [PCv2] Add tracing category needed for computing ttfmp The time-to-first-meaningful-paint computation requires extra tracing categories to be enabled. This CL enables recording of the category in PCv2. https://github.com/catapult-project/catapult/blob/master/tracing/tracing/metr... This is a reland of https://codereview.chromium.org/2049593002/ with disabling the benchmark on reference build. In the reference build, the disabled-by-default-blink.debug.layout category brows up trace size and causes d8 crash. BUG=615605,619254 ==========
The CQ bit was unchecked by nednguyen@google.com
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070773002/1
On 2016/06/17 12:04:40, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > https://chromium-cq-status.appspot.com/patch-status/2070773002/1 Rmoved cq_extra_trybot as the benchmarks are passing on most platforms. Failure in win64 is compile failure.
Message was sent while issue was closed.
Description was changed from ========== Reland: [PCv2] Add tracing category needed for computing ttfmp The time-to-first-meaningful-paint computation requires extra tracing categories to be enabled. This CL enables recording of the category in PCv2. https://github.com/catapult-project/catapult/blob/master/tracing/tracing/metr... This is a reland of https://codereview.chromium.org/2049593002/ with disabling the benchmark on reference build. In the reference build, the disabled-by-default-blink.debug.layout category brows up trace size and causes d8 crash. BUG=615605,619254 ========== to ========== Reland: [PCv2] Add tracing category needed for computing ttfmp The time-to-first-meaningful-paint computation requires extra tracing categories to be enabled. This CL enables recording of the category in PCv2. https://github.com/catapult-project/catapult/blob/master/tracing/tracing/metr... This is a reland of https://codereview.chromium.org/2049593002/ with disabling the benchmark on reference build. In the reference build, the disabled-by-default-blink.debug.layout category brows up trace size and causes d8 crash. BUG=615605,619254 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Reland: [PCv2] Add tracing category needed for computing ttfmp The time-to-first-meaningful-paint computation requires extra tracing categories to be enabled. This CL enables recording of the category in PCv2. https://github.com/catapult-project/catapult/blob/master/tracing/tracing/metr... This is a reland of https://codereview.chromium.org/2049593002/ with disabling the benchmark on reference build. In the reference build, the disabled-by-default-blink.debug.layout category brows up trace size and causes d8 crash. BUG=615605,619254 ========== to ========== Reland: [PCv2] Add tracing category needed for computing ttfmp The time-to-first-meaningful-paint computation requires extra tracing categories to be enabled. This CL enables recording of the category in PCv2. https://github.com/catapult-project/catapult/blob/master/tracing/tracing/metr... This is a reland of https://codereview.chromium.org/2049593002/ with disabling the benchmark on reference build. In the reference build, the disabled-by-default-blink.debug.layout category brows up trace size and causes d8 crash. BUG=615605,619254 Committed: https://crrev.com/e598d9f6f9d6bf4cd90c46503cb0c207791a02db Cr-Commit-Position: refs/heads/master@{#400426} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e598d9f6f9d6bf4cd90c46503cb0c207791a02db Cr-Commit-Position: refs/heads/master@{#400426} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
