Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2070753003: Revert "Add a new app API to enable watchdog behavior restarts in kiosk apps" (Closed)

Created:
4 years, 6 months ago by benwells
Modified:
4 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Add a new app API to enable watchdog behavior restarts in kiosk apps" This reverts commit 6c1c80d89c29b22117b13760643c7fd1734e2466. This change was reverted because it fails under DrMemory. First failing build is: https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%285%29/builds/7514 Sample failure output: RestartAfterDelayApiTest.RestartAfterDelayTest: c:\b\build\slave\drm-cr\build\src\extensions\browser\api\runtime\restart_after_delay_api_unittest.cc(230): error: The difference between (desired_restart_time() - last_restart_time).InSecondsF() and base::TimeDelta::FromSeconds(2).InSecondsF() is 0.025495000000000045, which exceeds 0.01, where (desired_restart_time() - last_restart_time).InSecondsF() evaluates to 1.974505, base::TimeDelta::FromSeconds(2).InSecondsF() evaluates to 2, and 0.01 evaluates to 0.01. TBR=afakhry@chromium.org BUG=604578 Committed: https://crrev.com/833b977639b4533097d60323c993d6a298ebe8db Cr-Commit-Position: refs/heads/master@{#400136}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -562 lines) Patch
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D extensions/browser/api/runtime/restart_after_delay_api_unittest.cc View 1 chunk +0 lines, -247 lines 0 comments Download
M extensions/browser/api/runtime/runtime_api.h View 8 chunks +4 lines, -80 lines 0 comments Download
M extensions/browser/api/runtime/runtime_api.cc View 6 chunks +2 lines, -207 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/test_extensions_browser_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/test_extensions_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/runtime.json View 1 chunk +0 lines, -18 lines 0 comments Download
M extensions/extensions_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
benwells
4 years, 6 months ago (2016-06-16 10:51:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070753003/1
4 years, 6 months ago (2016-06-16 10:51:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 12:28:15 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 12:28:21 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 12:30:08 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/833b977639b4533097d60323c993d6a298ebe8db
Cr-Commit-Position: refs/heads/master@{#400136}

Powered by Google App Engine
This is Rietveld 408576698