Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2070733002: Update omnibox dropdown selection/hover background drawing for MD. (Closed)

Created:
4 years, 6 months ago by Peter Kasting
Modified:
4 years, 6 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, tfarina, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@scaled_radius
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update omnibox dropdown selection/hover background drawing for MD. Rather than use full-window-width selections, return to using omnibox-width selections, but with a rounded corner to match the omnibox corner shape. BUG=612758 TEST=Type in the omnibox. The selected dropdown entry should have a selection background the same width as the omnibox, with the same rounded corners. Committed: https://crrev.com/367d9021063deb29a90571768d9b4b822f2f50be Cr-Commit-Position: refs/heads/master@{#400254}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use BackgroundWith1PxBorder to do the drawing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -55 lines) Patch
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc View 1 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.h View 1 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.cc View 1 8 chunks +36 lines, -29 lines 0 comments Download
M components/omnibox/browser/omnibox_popup_model.cc View 1 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Peter Kasting
4 years, 6 months ago (2016-06-15 22:37:16 UTC) #2
Evan Stade
there's a slight behavioral change here that I would argue with, which is that now ...
4 years, 6 months ago (2016-06-15 23:56:45 UTC) #3
Peter Kasting
On 2016/06/15 23:56:45, Evan Stade wrote: > there's a slight behavioral change here that I ...
4 years, 6 months ago (2016-06-16 00:52:48 UTC) #4
Evan Stade
https://codereview.chromium.org/2070733002/diff/1/chrome/browser/ui/views/omnibox/omnibox_result_view.cc File chrome/browser/ui/views/omnibox/omnibox_result_view.cc (right): https://codereview.chromium.org/2070733002/diff/1/chrome/browser/ui/views/omnibox/omnibox_result_view.cc#newcode712 chrome/browser/ui/views/omnibox/omnibox_result_view.cc:712: rect, BackgroundWith1PxBorder::kCornerRadius * scale + 1, paint); Would it ...
4 years, 6 months ago (2016-06-16 16:11:32 UTC) #5
Peter Kasting
https://codereview.chromium.org/2070733002/diff/1/chrome/browser/ui/views/omnibox/omnibox_result_view.cc File chrome/browser/ui/views/omnibox/omnibox_result_view.cc (right): https://codereview.chromium.org/2070733002/diff/1/chrome/browser/ui/views/omnibox/omnibox_result_view.cc#newcode712 chrome/browser/ui/views/omnibox/omnibox_result_view.cc:712: rect, BackgroundWith1PxBorder::kCornerRadius * scale + 1, paint); On 2016/06/16 ...
4 years, 6 months ago (2016-06-16 17:57:13 UTC) #6
Evan Stade
lgtm
4 years, 6 months ago (2016-06-16 18:30:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070733002/20001
4 years, 6 months ago (2016-06-16 20:07:49 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-16 20:56:01 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 20:59:16 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/367d9021063deb29a90571768d9b4b822f2f50be
Cr-Commit-Position: refs/heads/master@{#400254}

Powered by Google App Engine
This is Rietveld 408576698