Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2070723002: Revert of Blink image-decoders: (lazy) deferred image decoding support for ICO (Closed)

Created:
4 years, 6 months ago by tommycli
Modified:
4 years, 6 months ago
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, Stephen Chennney, blink-reviews, danakj+watch_chromium.org, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Blink image-decoders: (lazy) deferred image decoding support for ICO (patchset #8 id:140001 of https://codereview.chromium.org/2044093002/ ) Reason for revert: I think this broke a Dr Memory bot: First breaking build: https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%29/builds/5084 ICOImageDecoderTests.parseAndDecodeByteByByte: c:\b\build\slave\drm-cr\build\src\third_party\webkit\source\platform\image-decoders\imagedecodertesthelpers.cpp(83): error: Expected: (frameCount) <= (decoder->frameCount()), actual: 2 vs 0 c:\b\build\slave\drm-cr\build\src\third_party\webkit\source\platform\image-decoders\imagedecodertesthelpers.cpp(83): error: Expected: (frameCount) <= (decoder->frameCount()), actual: 3 vs 0 c:\b\build\slave\drm-cr\build\src\third_party\webkit\source\platform\image-decoders\imagedecodertesthelpers.cpp(83): error: Expected: (frameCount) <= (decoder->frameCount()), actual: 1 vs 0 c:\b\build\slave\drm-cr\build\src\third_party\webkit\source\platform\image-decoders\imagedecodertesthelpers.cpp(83): error: Expected: (frameCount) <= (decoder->frameCount()), actual: 1 vs 0 Original issue's description: > Blink image-decoders: (lazy) deferred image decoding support for ICO > > BUG=513306 > > Committed: https://crrev.com/de72effc185c6093879a0bc3379e38cb19b5b02b > Cr-Commit-Position: refs/heads/master@{#399855} TBR=scroggo@chromium.org,noel@chromium.org,fmalita@chromium.org,pkasting@chromium.org,aleksandar.stojiljkovic@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=513306 Committed: https://crrev.com/20684d8c982d782714864ee967625eb10d2ebc76 Cr-Commit-Position: refs/heads/master@{#400030}

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
tommycli
Created Revert of Blink image-decoders: (lazy) deferred image decoding support for ICO
4 years, 6 months ago (2016-06-15 22:35:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070723002/1
4 years, 6 months ago (2016-06-15 22:35:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 22:36:39 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 22:38:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20684d8c982d782714864ee967625eb10d2ebc76
Cr-Commit-Position: refs/heads/master@{#400030}

Powered by Google App Engine
This is Rietveld 408576698