Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: build/config/mips.gni

Issue 2070653003: Rework v8_target_arch / target_cpu approach to use v8_target_cpu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update w/ review feedback Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/arm.gni ('k') | build/config/v8_target_cpu.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/mips.gni
diff --git a/build/config/mips.gni b/build/config/mips.gni
index cc6d53f8bebe2843aeb4817580019515410bb409..e23e74885919cb113792c536c2763e8b691761ef 100644
--- a/build/config/mips.gni
+++ b/build/config/mips.gni
@@ -2,7 +2,13 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-if (current_cpu == "mipsel" || target_cpu == "mipsel") {
+import("//build/config/v8_target_cpu.gni")
+
+# These are primarily relevant in current_cpu == "mips*" contexts, where
+# MIPS code is being compiled. But they can also be relevant in the
+# other contexts when the code will change its behavior based on the
+# cpu it wants to generate code for.
+if (current_cpu == "mipsel" || v8_target_cpu == "mipsel") {
declare_args() {
# MIPS arch variant. Possible values are:
# "r1"
@@ -27,7 +33,7 @@ if (current_cpu == "mipsel" || target_cpu == "mipsel") {
# "fpxx": sets the GCC -mfpxx option.
mips_fpu_mode = "fp32"
}
-} else if (current_cpu == "mips64el" || target_cpu == "mips64el") {
+} else if (current_cpu == "mips64el" || v8_target_cpu == "mips64el") {
# MIPS arch variant. Possible values are:
# "r2"
# "r6"
« no previous file with comments | « build/config/arm.gni ('k') | build/config/v8_target_cpu.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698