Rework v8_target_arch / target_cpu approach to use v8_target_cpu.

build/config/arm.gni

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import("//build/config/v8_target_cpu.gni")
+
 # These are primarily relevant in current_cpu == "arm" contexts, where
 # ARM code is being compiled.  But they can also be relevant in the
-# host toolchain context when target_cpu == "arm", where a host-side
-# build tool being built will change its behavior depending on the
-# details of the target configuration.
-if (target_cpu == "arm" || current_cpu == "arm") {
+# other contexts when the code will change its behavior based on the
+# cpu it wants to generate code for.
+if (v8_target_cpu == "arm" || current_cpu == "arm") {

[Nico, 2016/06/16 08:17:28]

ubernit: maybe swap the operands to || to match the mips file (and to put the
common case first)

[Dirk Pranke, 2016/06/16 17:35:05]

Acknowledged.

   declare_args() {
     # Version of the ARM processor when compiling on ARM. Ignored on non-ARM
     # platforms.
     arm_version = 7
 
     # The ARM floating point mode. This is either the string "hard", "soft", or
     # "softfp". An empty string means to use the default one for the
     # arm_version.
     arm_float_abi = ""
 
@@ skipping 58 matching lines @@
         arm_float_abi = "hard"
       }
     }
 
     if (arm_use_neon) {
       arm_fpu = "neon"
     } else {
       arm_fpu = "vfpv3-d16"
     }
   }
-} else if (current_cpu == "arm64" || target_cpu == "arm64") {
+} else if (current_cpu == "arm64" || v8_target_cpu == "arm64") {

[Michael Achenbach, 2016/06/16 07:49:55]

ocd nit: maybe turn the conditions around like for arm above:
v8_target_cpu == "arm64" || current_cpu == "arm64" 

[Dirk Pranke, 2016/06/16 17:35:05]

Ack.

   # arm64 supports only "hard".
   arm_float_abi = "hard"
   arm_use_neon = true
 }