Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: net/cert/cert_verify_proc_unittest.cc

Issue 207063003: Add missing call to TestRootCerts::Clear() after usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add missing calls to TestRootCerts::Clear() Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/cert_verify_proc_unittest.cc
diff --git a/net/cert/cert_verify_proc_unittest.cc b/net/cert/cert_verify_proc_unittest.cc
index 9d7e7503ba4d62ed1c79cf1b741a88d0d9674c5b..3b6732dcaf496c35f9453cc930e68452f60fa5e1 100644
--- a/net/cert/cert_verify_proc_unittest.cc
+++ b/net/cert/cert_verify_proc_unittest.cc
@@ -1013,6 +1013,9 @@ TEST_F(CertVerifyProcTest, IsIssuedByKnownRootIgnoresTestRoots) {
EXPECT_EQ(0U, verify_result.cert_status);
// But should not be marked as a known root.
EXPECT_FALSE(verify_result.is_issued_by_known_root);
+
+ root_certs->Clear();
wtc 2014/03/25 16:00:19 Please add a comment to note why it is necessary t
haavardm 2014/03/25 17:18:03 This call is done like this many places (basically
wtc 2014/03/25 22:24:13 I see. If you think adding a comment for all of th
+ EXPECT_TRUE(root_certs->IsEmpty());
}
#if defined(OS_MACOSX) && !defined(OS_IOS)
@@ -1133,6 +1136,8 @@ TEST_F(CertVerifyProcTest, CybertrustGTERoot) {
EXPECT_EQ(OK, error);
EXPECT_EQ(0U, verify_result.cert_status);
+ TestRootCerts::GetInstance()->Clear();
+ EXPECT_TRUE(TestRootCerts::GetInstance()->IsEmpty());
}
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698