Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2070603002: Update WATCHLISTS file. (Closed)

Created:
4 years, 6 months ago by mmenke
Modified:
4 years, 6 months ago
Reviewers:
eroman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update WATCHLISTS file. Update net_log entry, remove mmenke as a watcher of dns entry and delete it, since no one is using it, and add mmenke as a watcher of content_loader. Committed: https://crrev.com/59e4d8fb4da272b9bbb61c0e2a45becdc223ddaa Cr-Commit-Position: refs/heads/master@{#400011}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Response to comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M WATCHLISTS View 1 4 chunks +5 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
mmenke
4 years, 6 months ago (2016-06-15 17:51:08 UTC) #3
eroman
lgtm https://codereview.chromium.org/2070603002/diff/1/WATCHLISTS File WATCHLISTS (right): https://codereview.chromium.org/2070603002/diff/1/WATCHLISTS#newcode596 WATCHLISTS:596: 'chrome/browser/ui/webui/net_internals/' While you are editing this, I suggest ...
4 years, 6 months ago (2016-06-15 19:46:53 UTC) #4
mmenke
https://codereview.chromium.org/2070603002/diff/1/WATCHLISTS File WATCHLISTS (right): https://codereview.chromium.org/2070603002/diff/1/WATCHLISTS#newcode596 WATCHLISTS:596: 'chrome/browser/ui/webui/net_internals/' On 2016/06/15 19:46:53, eroman wrote: > While you ...
4 years, 6 months ago (2016-06-15 20:11:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070603002/20001
4 years, 6 months ago (2016-06-15 20:11:45 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-15 21:15:41 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 21:17:25 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/59e4d8fb4da272b9bbb61c0e2a45becdc223ddaa
Cr-Commit-Position: refs/heads/master@{#400011}

Powered by Google App Engine
This is Rietveld 408576698