Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2070583002: S390: [turbofan] Prevent storing signalling NaNs into holey double arrays. (Closed)

Created:
4 years, 6 months ago by john.yan
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [turbofan] Prevent storing signalling NaNs into holey double arrays. Port 6470ddadf93594657acee02b5ce5459752928490 Original commit message: This introduces SilenceNaN operator, which makes sure that we only store quiet NaNs into holey arrays. We omit the NaN silencing code at instruction selection time if the input is an operation that cannot possibly produce signalling NaNs. R=jarin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com BUG= LOG=N Committed: https://crrev.com/2dedf2154e761f337fbfe494d0cc45106debbd6e Cr-Commit-Position: refs/heads/master@{#37012}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M src/compiler/s390/code-generator-s390.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M src/compiler/s390/instruction-codes-s390.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/s390/instruction-scheduler-s390.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
john.yan
PTAL
4 years, 6 months ago (2016-06-15 15:01:46 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070583002/1
4 years, 6 months ago (2016-06-15 15:02:06 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-15 15:30:25 UTC) #5
JaideepBajwa
lgtm
4 years, 6 months ago (2016-06-15 15:35:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070583002/1
4 years, 6 months ago (2016-06-15 16:45:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 16:47:22 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 16:49:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2dedf2154e761f337fbfe494d0cc45106debbd6e
Cr-Commit-Position: refs/heads/master@{#37012}

Powered by Google App Engine
This is Rietveld 408576698