third_party/WebKit/Source/core/frame/DOMWindow.h - Issue 2070563002: Seperate DOMVisualViewport from Blink's VisualViewport class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DOMWindow.h

Issue 2070563002: Seperate DOMVisualViewport from Blink's VisualViewport class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/DOMVisualViewport.cpp ('k') | third_party/WebKit/Source/core/frame/LocalDOMWindow.h » ('j') | third_party/WebKit/Source/core/frame/Window.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/DOMWindow.h

diff --git a/third_party/WebKit/Source/core/frame/DOMWindow.h b/third_party/WebKit/Source/core/frame/DOMWindow.h

index 73e89efe27f5df72160a2af3d4409ab02cbdd881..e4e7751224d0106eecd427617f41bae2c29a540e 100644

--- a/third_party/WebKit/Source/core/frame/DOMWindow.h

+++ b/third_party/WebKit/Source/core/frame/DOMWindow.h

@@ -22,6 +22,7 @@ class CSSRuleList;

class CSSStyleDeclaration;

class CustomElementsRegistry;

class DOMSelection;

+class DOMVisualViewport;

class DOMWindowCSS;

class Document;

class Element;

@@ -41,7 +42,6 @@ class ScrollToOptions;

class SerializedScriptValue;

class Storage;

class StyleMedia;

-class VisualViewport;

class CORE_EXPORT DOMWindow : public EventTargetWithInlineData, public DOMWindowBase64 {

DEFINE_WRAPPERTYPEINFO();

@@ -92,7 +92,7 @@ public:

double pageXOffset() const { return scrollX(); }

double pageYOffset() const { return scrollY(); }

- virtual VisualViewport* visualViewport() { return nullptr; }

+ virtual DOMVisualViewport* visualViewport() { return nullptr; }

bool closed() const;