Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1782)

Unified Diff: third_party/WebKit/Source/core/frame/DOMVisualViewport.h

Issue 2070563002: Seperate DOMVisualViewport from Blink's VisualViewport class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/DOMVisualViewport.h
diff --git a/third_party/WebKit/Source/core/testing/LayerRectList.h b/third_party/WebKit/Source/core/frame/DOMVisualViewport.h
similarity index 71%
copy from third_party/WebKit/Source/core/testing/LayerRectList.h
copy to third_party/WebKit/Source/core/frame/DOMVisualViewport.h
index dfed5020aaf569dd4239f74194a299197ff6ba2a..95f35e689c17886c08bd1bd4c41db58a7a467ab4 100644
--- a/third_party/WebKit/Source/core/testing/LayerRectList.h
+++ b/third_party/WebKit/Source/core/frame/DOMVisualViewport.h
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2013 Google Inc. All rights reserved.
+ * Copyright (C) 2016 Google Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
@@ -28,40 +28,42 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef LayerRectList_h
-#define LayerRectList_h
+#ifndef DOMVisualViewport_h
+#define DOMVisualViewport_h
#include "bindings/core/v8/ScriptWrappable.h"
#include "platform/heap/Handle.h"
-#include "wtf/Vector.h"
-#include "wtf/text/WTFString.h"
namespace blink {
-class ClientRect;
-class LayerRect;
-class Node;
+class LocalDOMWindow;
-class LayerRectList final : public GarbageCollected<LayerRectList>, public ScriptWrappable {
+class DOMVisualViewport final
+ : public GarbageCollected<DOMVisualViewport>
+ , public ScriptWrappable {
DEFINE_WRAPPERTYPEINFO();
public:
- static LayerRectList* create()
+ static DOMVisualViewport* create(LocalDOMWindow* window)
{
- return new LayerRectList;
+ return new DOMVisualViewport(window);
}
- unsigned length() const;
- LayerRect* item(unsigned index);
- void append(Node* layerAssociatedNode, const String& layerName, int layerOffsetX, int layerOffsetY, ClientRect* layerRelativeRect);
+ DECLARE_VIRTUAL_TRACE();
- DECLARE_TRACE();
+ double scrollLeft();
+ double scrollTop();
+ void setScrollLeft(double x);
+ void setScrollTop(double y);
+ double clientWidth();
+ double clientHeight();
+ double pageScale();
private:
- LayerRectList();
+ explicit DOMVisualViewport(LocalDOMWindow*);
- HeapVector<Member<LayerRect>> m_list;
+ Member<LocalDOMWindow> m_window;
};
} // namespace blink
-#endif // ClientRectList_h
+#endif // DOMVisualViewport_h

Powered by Google App Engine
This is Rietveld 408576698