third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js - Issue 2070563002: Seperate DOMVisualViewport from Blink's VisualViewport class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js

Issue 2070563002: Seperate DOMVisualViewport from Blink's VisualViewport class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-iframe.html » ('j') | third_party/WebKit/Source/core/frame/Window.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js

diff --git a/third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js b/third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js

index 57ae0170a6dbdb95aeaf1023748881a2985abb77..5cbd31604727f7d460aacdc363de3862d429c387 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js

+++ b/third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js

@@ -37,12 +37,6 @@ function emitExpectedResult(path, expected)

if (path.length >= 2 && (path[0] == 'console' || path[0] == 'performance') && path[1] == 'memory')

return;

- // TODO(bokan): Skip visualViewport for now since it returns the page-global VisualViewport

- // object and we have no way of creating a VisualViewport yet. This should be fixed with

- // crbug.com/604928.

- if (path[0] == 'visualViewport')

- return;

// Skip things that are assumed to be constants.

if (path[path.length - 1].toUpperCase() == path[path.length - 1])

return;