third_party/WebKit/Source/core/frame/LocalDOMWindow.h - Issue 2070563002: Seperate DOMVisualViewport from Blink's VisualViewport class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalDOMWindow.h

Issue 2070563002: Seperate DOMVisualViewport from Blink's VisualViewport class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/DOMVisualViewport.cpp ('K') | « third_party/WebKit/Source/core/frame/DOMWindow.h ('k') | third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/LocalDOMWindow.h

diff --git a/third_party/WebKit/Source/core/frame/LocalDOMWindow.h b/third_party/WebKit/Source/core/frame/LocalDOMWindow.h

index 87e5acdf973f9d8ae27b7edabf7c43877553bec8..d40182a6a681aeaebe7d985007000a189437d73a 100644

--- a/third_party/WebKit/Source/core/frame/LocalDOMWindow.h

+++ b/third_party/WebKit/Source/core/frame/LocalDOMWindow.h

@@ -56,7 +56,7 @@ class Page;

class PostMessageTimer;

class SecurityOrigin;

class SourceLocation;

-class VisualViewport;

+class DOMVisualViewport;

enum PageshowEventPersistence {

PageshowEventNotPersisted = 0,

@@ -106,7 +106,7 @@ public:

int screenY() const override;

double scrollX() const override;

double scrollY() const override;

- VisualViewport* visualViewport() override;

+ DOMVisualViewport* visualViewport() override;

const AtomicString& name() const override;

void setName(const AtomicString&) override;

String status() const override;

@@ -230,6 +230,7 @@ private:

Member<WindowFrameObserver> m_frameObserver;

Member<Document> m_document;

+ Member<DOMVisualViewport> m_visualViewport;

bool m_shouldPrintWhenFinishedLoading;