third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-iframe.html - Issue 2070563002: Seperate DOMVisualViewport from Blink's VisualViewport class

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-iframe.html

Issue 2070563002: Seperate DOMVisualViewport from Blink's VisualViewport class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt ('K') | « third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js ('k') | third_party/WebKit/Source/core/core.gypi » ('j') | third_party/WebKit/Source/core/frame/DOMVisualViewport.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 ::-webkit-scrollbar {

	4 width: 0px;

	5 height: 0px;
	bokan 2016/06/16 07:22:43 Lets use normal scrollbars and give the iframe som Lets use normal scrollbars and give the iframe some scrollable content (you can use the srcdoc iframe attribute), to make sure we're returning cilentWidth/Height not including scrollbars. ymalik 2016/06/20 15:52:56 Done. Show quoted text On 2016/06/16 07:22:43, bokan wrote: > Lets use normal scrollbars and give the iframe some scrollable content (you can > use the srcdoc iframe attribute), to make sure we're returning > cilentWidth/Height not including scrollbars. Done.
	6 }

	7 body {

	8 height: 2000px;

	9 width: 2000px;

	10 }

	11 #frame {

	12 height: 500px;

	13 width: 200px;

	14 }

	15 </style>

	16 <script src="../../../resources/testharness.js"></script>

	17 <script src="../../../resources/testharnessreport.js"></script>

	18 <script>

	19 async_test(function(t) {

	20 window.onload = t.step_func(function() {

	21 internals.setPageScaleFactor(2);

	22

	23 // verify visualViewport dimensions on containing iframe.

	24 var frame = document.getElementById("frame");

	25 assert_equals(frame.contentWindow.visualViewport.clientWidth, 200);

	26 assert_equals(frame.contentWindow.visualViewport.clientHeight, 500);

	27 assert_equals(frame.contentWindow.visualViewport.scrollTop, 0);

	28 assert_equals(frame.contentWindow.visualViewport.scrollLeft, 0);

	29 assert_equals(frame.contentWindow.visualViewport.pageScale, 1);

	30

	31 t.done();

	32 });

	33 }, 'Verify viewport dimensions for iframe.');

	34 </script>

	35 <iframe id="frame" src="about:blank"></iframe>

OLD	NEW