Issue 2070553002: Fix "ignore:" handling with upper case error codes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2070553002: Fix "ignore:" handling with upper case error codes. (Closed)

Created:
4 years, 6 months ago by Paul Berry

Modified:
4 years, 6 months ago

Reviewers:
pquitslund

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix "ignore:" handling with upper case error codes. Problem was introduced in c77781d27e54fdf04721b8b5890576a91619e976, which inadvertently dropped a call to toLowerCase(). R=pquitslund@google.com Committed: https://github.com/dart-lang/sdk/commit/2eed3a1de31c486185d4944664ef63ff501624f4

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	pkg/analyzer/lib/src/task/dart.dart	View		1 chunk	+4 lines, -2 lines	0 comments	Download
	M	pkg/analyzer/test/generated/error_suppression_test.dart	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

4 years, 6 months ago (2016-06-15 13:30:49 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2eed3a1de31c486185d4944664ef63ff501624f4 (presubmit successful).