Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2070513002: Revert "Revert "Make Safari tests more robust."" (Closed)

Created:
4 years, 6 months ago by Bill Hesse
Modified:
4 years, 6 months ago
Reviewers:
ahe, kustermann
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Revert "Make Safari tests more robust."" This reverts commit b9cdd0e1b2fba6753bd91e2a00347fde556d98aa. This change should now work, because the buildbot recipes use the renamed flag --reset-browser-configuration. BUG= R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/f76236db7423535b0293b2f0e59c74d6728d5698

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+508 lines, -172 lines) Patch
M tests/co19/co19-dart2js.status View 6 chunks +35 lines, -5 lines 0 comments Download
M tests/html/html.status View 1 chunk +4 lines, -2 lines 0 comments Download
M tools/bots/compiler.py View 1 chunk +1 line, -1 line 0 comments Download
A tools/safari_factory_reset.py View 1 chunk +27 lines, -0 lines 0 comments Download
M tools/testing/dart/browser_controller.dart View 18 chunks +208 lines, -160 lines 0 comments Download
A tools/testing/dart/reset_safari.dart View 1 chunk +227 lines, -0 lines 0 comments Download
M tools/testing/dart/test_configurations.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_options.dart View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
4 years, 6 months ago (2016-06-15 11:09:16 UTC) #2
ahe
lgtm
4 years, 6 months ago (2016-06-15 11:18:20 UTC) #3
Bill Hesse
4 years, 6 months ago (2016-06-15 11:29:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f76236db7423535b0293b2f0e59c74d6728d5698.

Powered by Google App Engine
This is Rietveld 408576698